/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Correct an error in the rule for nTime; also wording clarification #1485

Merged
merged 1 commit into from Jan 27, 2017

Conversation

Reviewers
No reviews
Assignees

@wbnns wbnns

Labels
Merge Scheduled
Projects
None yet
Milestone
No milestone
3 participants
@daira @wbnns @Cobra-Bitcoin
@daira
Contributor

daira commented Jan 12, 2017

nTime must be strictly greater than the median nTime of the previous 11 blocks, not just greater or equal:
https://github.com/bitcoin/bitcoin/blob/fac0f30482d56c7a38e9bdd7a4090b896965f030/src/validation.cpp#L2910
@daira
Correct an error in the rule for nTime; also wording clarification fo… 
…r nonce

nTime must be strictly greater than the median nTime of the previous 11 blocks, not just greater or equal:
https://github.com/bitcoin/bitcoin/blob/fac0f30482d56c7a38e9bdd7a4090b896965f030/src/validation.cpp#L2910
2c5ed58

@wbnns wbnns assigned Cobra-Bitcoin and wbnns and unassigned Cobra-Bitcoin Jan 13, 2017

@wbnns
Contributor

wbnns commented Jan 21, 2017

@daira Hello, thank you for submitting this.

Unless others object, this will be merged on Wednesday, January 25th.

@wbnns wbnns added the Merge Scheduled label Jan 21, 2017

@wbnns wbnns merged commit 9257dc5 into bitcoin-dot-org:master Jan 27, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@daira
Contributor

daira commented Jan 27, 2017

Hmm, is there a delay before this is reflected in the site contents? I don't see the change at https://bitcoin.org/en/developer-reference#block-headers
@wbnns
Contributor

wbnns commented Feb 5, 2017

@daira Hi, it's live - it just had to be deployed alongside some other changes first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment