Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

update info about TREZOR hardware wallet #1501

Merged
merged 1 commit into from Feb 13, 2017

Conversation

Projects
None yet
3 participants
Contributor

prusnak commented Feb 7, 2017 edited

TREZOR has been here for a few years already and is used by several thousands of people all around the world, so I think it deserves more than just a "New app" ranking.

I used transparency: "checkgoodtransparencydeterministic", because our firmware can be built deterministically using Docker and one can verify that the fingerprint of the firmware distributed by us is the same as the fingerprint of the firmware built locally.

Also the product name is TREZOR, not Trezor.

@prusnak prusnak changed the title from TREZOR is not a "New app" anymore to update info about TREZOR hardware wallet Feb 7, 2017

@wbnns wbnns self-assigned this Feb 7, 2017

@wbnns wbnns added the Under Review label Feb 7, 2017

@crwatkins crwatkins self-assigned this Feb 8, 2017

Contributor

crwatkins commented Feb 8, 2017

@prusnak Thanks for submitting such a well deserved scoring update! I concur with the choice of checkgoodtransparencydeterministic.

Bitcoin.org tends to use the Wikipedia Manual of Style for trademark representation as previously discussed specifically regarding Trezor. If you can revert the spelling change, I will be very happy to recommend the scoring update.

Also note that the new https://trezor.io site does not meet the bitcoin.org HSTS criteria for listing. I suspect you will want to get that updated shortly.

Contributor

prusnak commented Feb 8, 2017

Reverted capitalization of the TREZOR.

HSTS for trezor.io is something we'll do soon, but we wanted things to settle down after the domain migratrions before we did something that is impossible to change afterwards.

Contributor

crwatkins commented Feb 8, 2017

LGTM. @prusnak Thanks again.

Contributor

wbnns commented Feb 8, 2017

@crwatkins @prusnak Thanks!

Unless others object, this will be merged on Sunday, February 12th.

@wbnns wbnns added Merge Scheduled and removed Under Review labels Feb 8, 2017

@wbnns wbnns merged commit e9c537e into bitcoin-dot-org:master Feb 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@prusnak prusnak deleted the unknown repository branch Feb 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment