/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bitcoin Core 0.14.0 #1531

Merged
merged 3 commits into from Mar 8, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@laanwj @wbnns
@laanwj
Contributor

laanwj commented Mar 8, 2017

Add release announcement for 0.14.0.
Should be merge-able as soon as Travis passes.
@laanwj
Bitcoin Core 0.14.0
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits

All checks have failed

2 failing checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
continuous-integration/travis-ci/push — The Travis CI build failed
Details
4a6e477
@laanwj
Contributor

laanwj commented Mar 8, 2017 • edited

@wbnns any idea what is going wrong with the checks?

_site/en/release/v0.14.0.html:      <td><code class="highlighter-rouge">getnetworkinfo()["networks"]\[0\]["proxy"]</code></td>
_site/en/release/v0.14.0.html:array index or a non-quoted string (i.e. <code class="highlighter-rouge">listunspent()\[0\][txid]</code>). Both
make: *** [check-for-broken-markdown-reference-links] Error 1

AFAIK that part should be valid markdown. I already tried adding \ to escape but that didn't work, either.
Now trying html entity escaping...
@laanwj
Hopefully make verify stop complaining about "array index or a non-qu… 
…oted string"
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits

All checks have failed

2 failing checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
continuous-integration/travis-ci/push — The Travis CI build failed
Details
a707cc1
@laanwj
Contributor

laanwj commented Mar 8, 2017

That seems to have worked, new error though...

- ./_site/en/release/v0.14.0.html
  *  Unexpected end tag : a
/home/travis/build/bitcoin-dot-org/bitcoin.org/vendor/bundle/ruby/2.0.0/gems/html-proofer-2.1.0/lib/html/proofer.rb:179:in `print_failed_tests': HTML-Proofer found 1 failure! (RuntimeError)
@laanwj
Prevent # in link text 
Last time
(8e7c20e)
this was problematic. Try to fix it.
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
3b97afd

@laanwj laanwj merged commit 3b97afd into master Mar 8, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 8, 2017

@laanwj
Merge #1531: Bitcoin Core 0.14.0 
3b97afd Prevent # in link text (Wladimir J. van der Laan)
a707cc1 Hopefully make verify stop complaining about "array index or a non-quoted string" (Wladimir J. van der Laan)
4a6e477 Bitcoin Core 0.14.0 (Wladimir J. van der Laan)

Tree-SHA512: 5fe8bc38918766f306cbb6d70360ad19d4af922ee1b93d1d5088f75b3e2584ffb6467bce7e6781d093ec1098f0e4c2c1fabf60bb9de82ad92e8e258fb483cfd9
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits
4de3cb2
@laanwj
Contributor

laanwj commented Mar 8, 2017

That worked! merging.
@wbnns
Contributor

wbnns commented Mar 10, 2017

@laanwj Hey, glad you were able to figure this out. Sorry, I saw the notification after you had already fixed it.

@wbnns wbnns deleted the bitcoin-core-0.14.0 branch Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment