Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
P2P 'alert' messaging was removed, updating DevDocs (also updating protocol table to 70015) #1576
Conversation
| - | ||
| -**Resource:** More details about the structure of messages and a complete list of message types can be found in | ||
| -the [P2P reference section][section P2P reference]. | ||
| +Earlier versions of Bitcoin Core allowed developers and trusted community members to issue [Bitcoin alerts](https://bitcoin.org/en/alerts) to notify users of critical network-wide issues. This messaging system [was retired](https://bitcoin.org/en/alert/2016-11-01-alert-retirement) in Bitcoin Core v0.14.0; however, internal alerts, partition detection warnings and the `-alertnotify` option features remain. |
jonathancross
Apr 23, 2017
Contributor
This does not have to stay.
I'm perfectly happy being more aggressive and removing the entire "Alerts" section.
We still note the removal in the P2P network protocol table below which might be enough.
| -The `alert` message warns nodes of problems that may affect them or the |
jonathancross
Apr 23, 2017
Contributor
I am not familiar with "internal alerts" mentioned by @btcdrak in bitcoin/bitcoin#7692, is any of this deleted material relevant now?
wbnns
self-assigned this
Apr 24, 2017
|
I was incorrect about the Alert system being removed in 0.14.0. This has now been corrected. |
|
Good riddance. |
|
ACK |
| @@ -64,10 +63,11 @@ with the most recent versions listed first. (If you know of a protocol | ||
| version that implemented a major change but which is not listed here, | ||
| please [open an issue][docs issue].) | ||
| -As of Bitcoin Core 0.13.0, the most recent protocol version is 70014. | ||
| +As of Bitcoin Core 0.14.1, the most recent protocol version is 70015. |
achow101
May 8, 2017
Contributor
I think a description of the 70015 changes should be included in the table below.
| | Version | Initial Release | Major Changes | ||
| |---------|------------------------------------|-------------- | ||
| +| 70014 | Bitcoin Core 0.13.0 <br> | • Removed `alert` message system. See [Alert System Retirement](https://bitcoin.org/en/alert/2016-11-01-alert-retirement). |
achow101
May 8, 2017
Contributor
This line should be combined with the line below which also describes 70014
| @@ -693,102 +693,9 @@ d91f4854 ........................... Epoch time: 1414012889 | ||
| {% autocrossref %} | ||
| *Added in protocol version 311.* | ||
| +*Removed in Bitcoin Core 0.13.0* |
jonathancross
May 9, 2017
Contributor
Since alert removal did not get its own protocol number increase, I was not 100% sure what to use here.
The protocol number was 70012 when bitcoin/bitcoin#7692 was merged on Mar 21, 2016. Then the protocol was bumped to 70013 a few hours later for feefilter in #7542, then again to 70014 before v0.13.0 was finally released.
70013 was the first version where the feature did not exist, so I used that version number. Am I understanding that correctly?
| @@ -64,10 +63,11 @@ with the most recent versions listed first. (If you know of a protocol | ||
| version that implemented a major change but which is not listed here, | ||
| please [open an issue][docs issue].) | ||
| -As of Bitcoin Core 0.13.0, the most recent protocol version is 70014. | ||
| +As of Bitcoin Core 0.14.1, the most recent protocol version is 70015. |
| | Version | Initial Release | Major Changes | ||
| |---------|------------------------------------|-------------- | ||
| +| 70014 | Bitcoin Core 0.13.0 <br> | • Removed `alert` message system. See [Alert System Retirement](https://bitcoin.org/en/alert/2016-11-01-alert-retirement). |
| -| 70014 | Bitcoin Core 0.13.0 <br> | [BIP152][]: <br>• Added `sendcmpct`, `cmpctblock`, `getblocktxn`, `blocktxn` messages <br> * Added `MSG_CMPCT_BLOCK` inventory type to `getdata` message. | ||
| -| 70013 | Bitcoin Core 0.13.0 <br> | [BIP133][]: <br>• Added `feefilter` message | ||
| -| 70012 | Bitcoin Core 0.12.0 <br> | [BIP130][]: <br>• Added `sendheaders` message | ||
| +| 70015 | Bitcoin Core 0.13.2 <br> | • New banning behavior for invalid compact blocks [#9026](https://github.com/bitcoin/bitcoin/pull/9026) in v0.14.0, Backported to v0.13.2 in [#9048](https://github.com/bitcoin/bitcoin/pull/9048). |
jonathancross
May 9, 2017
Contributor
The protocol bump to 70015 was made in v0.14.0 (#9026), then backported to v0.13.2 in #9048.
Considering there was no clear announcement in release notes, I opted for this description with references to pull requests. Happy to change it if needed.
| @@ -693,102 +693,9 @@ d91f4854 ........................... Epoch time: 1414012889 | ||
| {% autocrossref %} | ||
| *Added in protocol version 311.* | ||
| +*Removed in Bitcoin Core 0.13.0* |
jonathancross
May 9, 2017
Contributor
Since alert removal did not get its own protocol number increase, I was not 100% sure what to use here.
The protocol number was 70012 when bitcoin/bitcoin#7692 was merged on Mar 21, 2016. Then the protocol was bumped to 70013 a few hours later for feefilter in #7542, then again to 70014 before v0.13.0 was finally released.
70013 was the first version where the feature did not exist, so I used that version number. Am I understanding that correctly?
| @@ -693,102 +693,9 @@ d91f4854 ........................... Epoch time: 1414012889 | ||
| {% autocrossref %} | ||
| *Added in protocol version 311.* | ||
| +*Removed in protocol version 70013 and released in Bitcoin Core v0.13.0* |
jonathancross
May 9, 2017
Contributor
Since alert removal did not get its own protocol number increase, I was not 100% sure what to use here.
The protocol number was 70012 when bitcoin/bitcoin#7692 was merged on Mar 21, 2016. Then the protocol was bumped to 70013 a few hours later for feefilter in #7542, then again to 70014 before v0.13.0 was finally released.
70013 was the first version where the feature did not exist, so I used that version number. Am I understanding that correctly?
harding
May 10, 2017
Contributor
I think that's reasonable.
As a nitpick, could you remove the v in v0.13.0? That will allow the auto-linker to link Bitcoin Core 0.13.0 to the release notes for that version as it does in the protocol versions table:
jonathancross
changed the title from
P2P 'alert' messaging was removed, updating DevDocs
to
P2P 'alert' messaging was removed, updating DevDocs (also updating protocol table to 70015)
May 9, 2017
harding
approved these changes
May 10, 2017
One tiny nitpick but otherwise tested ACK. Thanks, @jonathancross!
| @@ -693,102 +693,9 @@ d91f4854 ........................... Epoch time: 1414012889 | ||
| {% autocrossref %} | ||
| *Added in protocol version 311.* | ||
| +*Removed in protocol version 70013 and released in Bitcoin Core v0.13.0* |
harding
May 10, 2017
Contributor
I think that's reasonable.
As a nitpick, could you remove the v in v0.13.0? That will allow the auto-linker to link Bitcoin Core 0.13.0 to the release notes for that version as it does in the protocol versions table:
|
Thanks @harding, should be good to go now. |
|
LGTM |
|
8d84279 tested ACK. Thanks! |
|
Thanks everybody - unless others object, this will be merged on Sunday, May 14th (tomorrow). |
wbnns
added
the
Merge Scheduled
label
May 13, 2017
wbnns
merged commit 822947a
into
bitcoin-dot-org:master
May 14, 2017
1 check passed
|
Cheers, thanks everyone! |
jonathancross commentedApr 23, 2017
Now that v0.14.0 has shipped, it seemed like a good idea to update this info.
Suggestions / modifications welcome!
Most of this info was gathered from: