Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Updating 'alert system retirement' page. #1577
Conversation
| @@ -49,15 +50,15 @@ receive the final alert. | ||
| |---|---|---| | ||
| |Pre-final Alert Posts|Posts on Bitcoin.org, various forums, and various mailing lists that the Alert system will be retired|2016-11-01| | ||
| |Pre-final Alert|The alert itself warning that the Alert system will be retired|2016-11-02| | ||
| -|Final Alert|Max sequence Alert to disable the Alert system|2017 (Will coincide with Bitcoin Core 0.14 Release Candidate process)| | ||
| +|Final Alert|Max sequence Alert to disable the Alert system|2017-19-01| |
| are guaranteed to have removed/disabled the Alert system or allow you to disable it. | ||
| -* Bitcoin Core 0.13.1, 0.13.0, 0.12.1 | ||
| +* Bitcoin Core 0.14.1, 0.14.0, 0.13.1, 0.13.0, 0.12.1 |
|
Thanks @achow101, I've addressed your comments and squashed. |
jonathancross
referenced this pull request
Apr 26, 2017
Merged
P2P 'alert' messaging was removed, updating DevDocs (also updating protocol table to 70015) #1576
| @@ -49,15 +50,15 @@ receive the final alert. | ||
| |---|---|---| | ||
| |Pre-final Alert Posts|Posts on Bitcoin.org, various forums, and various mailing lists that the Alert system will be retired|2016-11-01| | ||
| |Pre-final Alert|The alert itself warning that the Alert system will be retired|2016-11-02| | ||
| -|Final Alert|Max sequence Alert to disable the Alert system|2017 (Will coincide with Bitcoin Core 0.14 Release Candidate process)| | ||
| +|Final Alert|Max sequence Alert to disable the Alert system|2017-01-19| | ||
| |Alert key released|The Alert key will be made publicly available|1-2 months after the Final Alert| |
jonathancross
Apr 26, 2017
•
Contributor
Date column here ("1-2 months after the Final Alert") needs updating at some point...
achow101
Apr 27, 2017
Contributor
According to @gmaxwell, there are some vulnerabilities in the Alert handling code that could be exploited if the alert key were released. He said that he would wait to publish it until after people have stopped using vulnerable software.
jonathancross
May 1, 2017
•
Contributor
Thanks for the feedback.
I've updated the wording as such:
"Older clients may contain Alert handling code which is exploitable using the alert key, therefore the public release of the key has been temporarily postponed until considered safe."
wbnns
assigned
Cobra-Bitcoin and
wbnns
and unassigned
Cobra-Bitcoin
Apr 28, 2017
|
I've updated the explanation for public release of alert key. |
| -|Final Alert|Max sequence Alert to disable the Alert system|2017 (Will coincide with Bitcoin Core 0.14 Release Candidate process)| | ||
| -|Alert key released|The Alert key will be made publicly available|1-2 months after the Final Alert| | ||
| +|Final Alert|Max sequence Alert to disable the Alert system|2017-01-19| | ||
| +|Alert key released|The Alert key will be made publicly available|Older clients may contain Alert handling code which is exploitable using the alert key, therefore the public release of the key has been temporarily postponed until considered safe.| |
achow101
May 1, 2017
Contributor
How about making this "Postponed until further notice" and moving the explanation to an update at the top of the page?
|
Anything more you all would like to see here? |
|
LGTM |
|
@jonathancross @achow101 Thanks! Unless others object, this will be merged on Wednesday, May 10th. |
wbnns
added
the
Merge Scheduled
label
May 8, 2017
|
Tested ACK. |
jonathancross commentedApr 24, 2017
If there is a known date for the alert key being published, I'm happy to add that too.
The date column states "1-2 months after the Final Alert" which has already passed. :-/