Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Events plugin: stop requesting events from Meetup.com #1620

Merged
merged 2 commits into from Jun 8, 2017

Conversation

Projects
None yet
3 participants
Contributor

harding commented Jun 3, 2017

Closes #1617

In testing, the only rendered HTML changes to the site were three fewer lines of whitespace per rendered translation of the Events page.

I also checked the Events RSS feed and it appeared that we never included any Meetups information in it, so no changes were required there.

Events plugin: stop requesting events from Meetup.com
Closes #1617 (Meetup.com events no longer display)

@wbnns wbnns self-assigned this Jun 5, 2017

Contributor

wbnns commented Jun 5, 2017

@harding Thanks

Unless others object, this will be merged on Wednesday, June 7th.

Contributor

Mirobit commented Jun 5, 2017

@harding Submitted a pull request updating the docs regarding the removal of meetup.

Contributor

harding commented Jun 5, 2017

@Mirobit thanks for catching that! I added your commit a492959 to this branch, but GitHub isn't showing it here (and isn't showing it as merged on your PR), even though it does show on the branch itself. I think this is a bug in GitHub, so I'll wait a few hours to see if it resolves itself before poking at it.

Thanks again!

Contributor

harding commented Jun 5, 2017

Seems to be mostly working now. @Mirobit's commit is showing on this page and in the diff view, but Travis is not checking it (not that it should---the internal site docs are not checked).

@wbnns I think this remains ready for Wednesday merge, baring objections, but please feel free to move back the planned merge if you want to give others a chance to review the additional commit.

@wbnns wbnns merged commit 6148ba1 into bitcoin-dot-org:master Jun 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment