/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use shiny flags #1624

Merged
merged 1 commit into from Jun 11, 2017

Conversation

Reviewers
No reviews
Assignees

@wbnns wbnns

Labels
Merge Scheduled
Projects
None yet
Milestone
No milestone
3 participants
@Mirobit @harding @wbnns
@Mirobit
Contributor

Mirobit commented Jun 8, 2017 • edited

I think it gives the pages a more modern look.
Changes Community and Bitcoin Exchanges

Old:
old

New:
new
@harding
Contributor

harding commented Jun 8, 2017

Old combined size of all flags was 19,102 bytes; new combined size is 60,211 bytes. A 40KB increase in just two pages seems perfectly fine to me, and I agree the new flags look nicer. I tested with optipng per site policy to ensure flags were maximally compressed, and they were, so this LGTM.

Thanks, @Mirobit!
@wbnns
Contributor

wbnns commented Jun 9, 2017

@Mirobit @harding LGTM. 👍

Unless others object, this will be merged on Sunday, June 11th.

@wbnns wbnns added the Merge Scheduled label Jun 9, 2017

@wbnns wbnns self-assigned this Jun 9, 2017

@wbnns wbnns merged commit a563ab5 into bitcoin-dot-org:master Jun 11, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Mirobit Mirobit deleted the Mirobit:shinyflags branch Jul 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment