Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add subtractfeeamount parameter #1626
Conversation
|
LGTM |
|
Ideally this change would also add the subtractfromfee parameter for Not related to this PR, but ideally someone should add a part for the name based RPC parameter option: bitcoin/bitcoin#8811 |
|
I'll add the parameter to |
harding
suggested changes
Jun 13, 2017
One small nit, otherwise tested ACK. I think we already have this documented for fundrawtransaction, but adding it for sendmany would be appreciated. Thanks @d2597b33-2ac1-4c27-af8e-5794285e8600 !
| @@ -56,14 +56,24 @@ The `sendtoaddress` RPC {{summary_sendToAddress}} | ||
| {% enditemplate %} | ||
| +*Parameter #5---automatic fee subtraction |
|
@jonasschnelli you're the second person to suggest adding named parameters to me this week, so it's nearing the top of my todo list (I didn't realize support for that was added until the first person told me). Adding a note about it to the RPC intro section should be easy, but I think to fully add it to the docs we'll have to add all of the input parameter names to each RPC call, which will take a little bit more time. Thanks for the suggestion! |
| @@ -64,6 +64,11 @@ All existing inputs must have their previous output transaction be in the wallet | ||
| t: "numeric (bitcoins)" | ||
| p: "Optional<br>(0 or 1)" | ||
| d: "The specific feerate you are willing to pay(BTC per KB). If not set, the wallet determines the fee" | ||
| + | ||
| +- n: "→ <br>`subtractFeeFromOutputs`" |
harding
Jun 13, 2017
Contributor
This field is already documented (see lines 68-71 in the original or 73-76 in this version), and in this call the parameter is an array of integers not a bool.
d2597b33-2ac1-4c27-af8e-5794285e8600
Jun 13, 2017
Contributor
Sorry, I don't know how I missed that.
| @@ -55,6 +55,16 @@ The `sendmany` RPC {{summary_sendMany}} | ||
| {% enditemplate %} | ||
| +*Parameter #5---automatic fee subtraction |
| + | ||
| +{% itemplate ntpd1 %} | ||
| +- n: "Subtract Fee From Amount" | ||
| + t: "boolean" |
harding
Jun 13, 2017
Contributor
In the sendmany call, this is an array of strings (addresses) rather than a single bool for the whole transaction.
|
Unless others object, this will be merged on Wednesday, June 14th. |
wbnns
self-assigned this
Jun 13, 2017
wbnns
added
the
Merge Scheduled
label
Jun 13, 2017
|
I sent @d2597b33-2ac1-4c27-af8e-5794285e8600 a quick PR to make the changes (and some related existing text) consistent with our normal style. Thanks again for catching this omission! |
|
@harding, I merged your PR into my branch. Hopefully I did it that correctly. Thanks again :) |
|
ab16005 tested ACK. Thanks! |
d2597b33-2ac1-4c27-af8e-5794285e8600 commentedJun 12, 2017
•
edited
Functionality was merged into Bitcoin Core in March '15 which I think is Bitcoin Core 0.10.1?
Here it is in the latest version: https://github.com/bitcoin/bitcoin/blob/e4918316d80f0541189c40039095c716a09d636e/src/wallet/rpcwallet.cpp#L403