Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added Exchanges in Nepal #1642

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants

Added Nepal's first exchange "Bitsewa" and Nepal's flag.

About Bitsewa

Bitsewa is Nepal's first Bitcoin exchange, which has been operating for nearly 8 months now. Bitsewa exchange provides best rates with automated and instant buying/selling of Bitcoin and many Digital Assets. Bitsewa has been operating under the company called "Bitsewa Pvt. Ltd." and they are legally registered software company in Nepal which can be verified at government company registration website: http://www.ocr.gov.np/index.php/en/

For more details contact me or email at support@bitsewa.com

tuladhar added some commits Jun 22, 2017

Add Exchanges in Nepal
Nepal now has Bitcoin exchange called Bitsewa (www.bitsewa.com) and has been operating for nearly 8 months now. Bitsewa is operating under the company called "Bitsewa Pvt. Ltd." and they are legally registered software company in Nepal which can be verified at government company registration website: http://www.ocr.gov.np/index.php/en/

For more details contact me or support@bitsewa.com
Add Nepalese Flag for Exchanges in Nepal
Image dimension: 48x48 pixels

@wbnns wbnns added the Under Review label Jun 23, 2017

@wbnns wbnns self-assigned this Jun 23, 2017

Contributor

wbnns commented Jun 25, 2017

@tuladhar Hi there! Thanks for submitting this. Could you please:

  1. Change the flag to this one.
  2. Rebase your PR to resolve the conflicts.

Once you've done that this LGTM. 👍

tuladhar commented Jun 25, 2017 edited

Hi @wbnns

Please kindly review the changes.

Hope I didn't messed up anything 🤞

Thanks

@tuladhar Thanks. Just one more change that I noted and then I think we're good to go.

Please let me know if you have any questions.

_templates/exchanges.html
@@ -168,6 +168,12 @@ <h3 id="mexico"><img src="/img/flags/MX.png" alt="Mexican flag">Mexico</h3>
</div>
<div>
<div>
+ <h3 id="nepal"><img src="/img/flags/NP.png" alt="Nepalese flag">Nepal</h3>
+ <p>
+ <a href="https://www.bitsewa.com/">Bitsewa</a><br>
@wbnns

wbnns Jun 25, 2017

Contributor

@tuladhar Please remove the <br> since there is only one entry for Nepal at the moment.

Thanks @wbnns It has been fixed on commit 7f01f05

wbnns approved these changes Jul 2, 2017

Contributor

wbnns commented Jul 2, 2017

@tuladhar Thanks a bunch for working on this. Another PR created a merge conflict here, so I went ahead and took care of adding Bitsewa for you in #1656 so you don't have to do anything else. 👍

@wbnns wbnns closed this Jul 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment