Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make preview charset fix #1651

Merged
merged 1 commit into from Jun 29, 2017

Conversation

Projects
None yet
3 participants
Contributor

Mirobit commented Jun 29, 2017 edited

Since the incremental build (#1643) update "make preview" leads to the following error:
Conversion error: Jekyll::Converters::Scss encountered an error while converting 'css/main.scss': Invalid US-ASCII character "\xE2" on line 2427 jekyll 3.0.1 | Error: Invalid US-ASCII character "\xE2" on line 2427
I don't know if this is the best solution but it fixes the error.

Contributor

harding commented Jun 29, 2017

Concept ACK and this should be safe for immediate merge since it's just changing the non-production preview target.. I'm testing now---I should have results in about 30 minutes.

Sorry, I didn't attempt to test incremental building outside my usual UTF-enabled environment. I think this solution is ideal given that the regular build target does exactly the same thing, and that's what we use in production.

Contributor

harding commented Jun 29, 2017

Tested ACK now. This change renders the CSS files (and all other files) in the preview target as in the production build target.

@wbnns wbnns merged commit a22e77a into bitcoin-dot-org:master Jun 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Contributor

wbnns commented Jun 29, 2017

@Mirobit Nice catch! @harding Thanks for double-checking.

Merged. 👍

@Mirobit Mirobit deleted the Mirobit:makeprevfix branch Jul 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment