Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
added bitcoinprojects.net to directories #1697
Conversation
wbnns
added
the
Under Review
label
Jul 21, 2017
wbnns
requested changes
Jul 24, 2017
@James-Sangalli Thanks for adding your site! Just left once comment requesting an update to the formatting, otherwise LGTM.
| @@ -29,6 +29,7 @@ <h2 id="directories"><img src="/img/icons/ico_invoice.svg" class="titleicon" alt | ||
| <p><a href="https://99bitcoins.com/who-accepts-bitcoins-payment-companies-stores-take-bitcoins/">{% translate linkmerchants %}</a> - 99Bitcoins.com</p> | ||
| <p><a href="https://www.buybitcoinworldwide.com/">{% translate linkexchanges %}</a> - buybitcoinworldwide.com</p> | ||
| <p><a href="https://en.bitcoin.it/wiki/Category:Shopping_Cart_Interfaces">{% translate linkmerchantstools %}</a> - en.bitcoin.it</p> | ||
| + <p><a href="http://www.bitcoinprojects.net/">BitcoinProjects.net</a></p> |
wbnns
Jul 24, 2017
Contributor
Could you please update this to match the formatting of the other entries?
Example:
Projects - bitcoinprojects.net
James-Sangalli
Jul 25, 2017
Contributor
Done, please let me know if any other amendments are needed. Thanks.
wbnns
self-assigned this
Jul 24, 2017
wbnns
added
Changes Requested
and removed
Under Review
labels
Jul 24, 2017
|
@James-Sangalli Awesome, thanks. Unless others object, this will be merged on Friday, July 28th. |
wbnns
added
Merge Scheduled
and removed
Changes Requested
labels
Jul 27, 2017
wbnns
merged commit 6fa1087
into
bitcoin-dot-org:master
Jul 31, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
James-Sangalli commentedJul 21, 2017
As per our discussion @wbnns I have added bitcoinprojects.net as a directories link.
Thanks a lot,
James