Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Upgrades Ruby version in Gemfile and Travis config #1715
Conversation
kuzzmi
added some commits
Jul 31, 2017
|
In fact it's even more visible on Travis: 13 min 12 sec with 2.4.1 |
wbnns
self-assigned this
Jul 31, 2017
wbnns
added
the
Under Review
label
Jul 31, 2017
kuzzmi
referenced this pull request
Aug 10, 2017
Closed
Document direct headers annoucement in block broadcasting guide. #1740
wbnns
added
On Hold
and removed
Under Review
labels
Sep 10, 2017
Cobra-Bitcoin
merged commit 954ceb0
into
bitcoin-dot-org:master
Sep 16, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kuzzmi commentedJul 31, 2017
This PR upgrades Ruby version as well as some dependencies (json library) to improve stability and minimize a risk of future upgrades. The library upgrade is necessary due to incompatibility with Ruby version > 2.0.0.
Apart from that I noticed slightly reduced build time using a newer version.
As stated in the instructions I need to notify site maintainers, in this case I assume that's @wbnns, that
rvm install 2.4.1also must be run on the build server before doing a merge.