Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update guide_transactions.md #1819

Merged
merged 2 commits into from Oct 7, 2017

Conversation

Projects
None yet
3 participants
Contributor

ujjwalmishra commented Sep 21, 2017

"the first output is output zero" should be made to "the index of first output is zero."

Update guide_transactions.md
"the first output is output zero" should be made to "the index of first output is zero."

@wbnns wbnns self-assigned this Sep 23, 2017

@wbnns wbnns added the Under Review label Sep 23, 2017

LGTM

@ujjwalmishra Thanks, I added a comment regarding a grammatical error.

_includes/devdoc/guide_transactions.md
@@ -47,7 +47,7 @@ invalidating previous transactions.
![Spending An Output](/img/dev/en-tx-overview-spending.svg)
An output has an implied index number based on its location in the
-transaction---the first output is output zero. The output also has an
+transaction---the index of first output is zero. The output also has an
@wbnns

wbnns Oct 7, 2017

Contributor

The word "the" is missing. Please change to: "the index of the first output"

Also, do not italicize; I only added it above to emphasis the change.

@wbnns wbnns added Changes Requested and removed Under Review labels Oct 7, 2017

Update guide_transactions.md
requested change made
thanks to @wbnns
Contributor

ujjwalmishra commented Oct 7, 2017

wbnns approved these changes Oct 7, 2017

@wbnns wbnns merged commit 2ed13af into bitcoin-dot-org:master Oct 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Contributor

wbnns commented Oct 7, 2017

@ujjwalmishra Ok, great, thanks!

@ujjwalmishra ujjwalmishra deleted the ujjwalmishra:patch-1 branch Oct 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment