Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Re-structure design and layout #215
Conversation
|
Looks okay on Qupzilla. Too many changes to look at each one individually right now... |
|
Sure, I will let at least a week for review. And re-ask one day before merging. |
|
Still reviewing, but I like the changes a lot so far. |
bitcoinuser
commented
Jul 24, 2013
|
Hi, |
|
Portable directory data : I agree on this. That said I think that these three points have a greater priority:
So far, it seems like usebitcoins.info is the directory that fulfills all of these needs. Data is public, so it could still be extracted with a script if someone really wanted to do it ( but if you want to suggest a concrete way to improve this, I invite you to contact the owner of usebitcoins.info ). Of course, if a better directory comes along, the link could be changed. Or maybe we can find a way to display more than one directory. That said, I tend to think that fragmentation and duplication is not helpful in this case both for people operating the directories, businesses who want to be listed, people who submit businesses and people who are searching for businesses. Unity would make a very good and efficient experience for anyone, as long as it's possible. |
|
I plan to merge this pull request in 2 days. More reviews are welcome. Especially reviews for typos and other text improvements ( in _translations/en.yml ). |
saivann commentedJul 14, 2013
This pull request can be previewed live here : http://bitcoinhome.zapto.org/en/
Most important changes in this pull requests:
This work has been done with the following goals in mind:
Tested browsers:
IE 6+
FF 3+
OP 10+
SA 3+
CH --
Android 2.3
Future improvements:
I planned to replace the About page by a FAQ later, and rewrite the Innovation page.
Migration:
Deprecated transitional HTML and CSS code is isolated in such a way that previous layouts will remain online for translations until they have been updated, after what it will be possible to drop this code.
Yes, it's a lot of changes:
Sorry for the huge pull request, doing these changes individually would produce an inconsistent result. I have already pushed many non-controversial changes to reduce the size of this pull requests as much as possible.