Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Recommend Bitcoin Wallet to non-technical people #243

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

schildbach commented Sep 16, 2013

No description provided.

Contributor

saivann commented Sep 16, 2013

Is "and available for Android" correct is English? Or should it be "and is available for Android"

Contributor

schildbach commented Sep 16, 2013

True enough. I changed that to two sentences.

Contributor

schildbach commented Sep 28, 2013

Ping. Anything else needed for merging this?

Contributor

luke-jr commented Sep 28, 2013

I'm not sure this is a good idea until it's actually a good idea for non-technical people to use it. Eg, at least get rid of the "from" address nonsense (it's my understanding this is planned).

Contributor

saivann commented Sep 28, 2013

I think that luke-jr talks about issue 49: https://code.google.com/p/bitcoin-wallet/issues/detail?id=49

@schildbach : This issue seemed easy to fix at a first glance, do you think you can take a look at it?

I agree with luke-jr that in general, "from" addresses don't make sense in a context where the general consensus is not to reuse addresses. Also in some cases, users could lose funds if they send it back to (one of) the input addresses, if they assume these addresses belong to someone in particular, which might often not be the case.

Note: Not sure this should be a stopper for merging this one, since we already recommend BW4A as the default option in "Get started fast and easy" and BW4A indeed seems to be the best mobile wallet option so far.

Contributor

schildbach commented Sep 28, 2013

I agree with you both. The issue with silently creating new addresses (and thus being able to distinguish payments if not by from address) is that the backup problem is not solved. I plan to move away from re-using addresses at the same time we migrate to BIP32 HD wallets.

Contributor

saivann commented Sep 28, 2013

(Correct me if I'm wrong)

My understanding of issue 49 is that it could be fixed with or without HD wallets (which could take time to be implemented). It is a simple GUI fix to display "received with" address instead of "received from" address. BW4A already allows users to manually create different addresses so this feature would allow them to see with which address they receive a payment (and encourage users to use new addresses for new payments). I suppose that this would work fine to distinguish payments (with the date, the amount paid and the "received with" address).

Edit: BW4A seems to allow to make a backup all private keys of all addresses it contains.

Contributor

schildbach commented Sep 28, 2013

Currently, you're required to back up the wallet each time after you added a key -- that's just not practical. BIP32 will take care of that by only needing to backup once. One backup covers all keys created in future.

Contributor

saivann commented Sep 28, 2013

Fair enough, this indeed probably isn't a good short-term solution if this leads to more private keys with no backup.

I will merge the pull req later today.

@saivann saivann closed this in 39e4faa Sep 28, 2013

Contributor

luke-jr commented Sep 29, 2013

Even without HD wallets, you could easily do a keypool like Bitcoin-Qt does.

@schildbach schildbach deleted the schildbach:bitcoinwallet-nontechnical branch Mar 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment