Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add missing wallets names, and changed order of wallets #274

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants

I noticed that the names of the wallets at the bottom of the page "choose your wallet" were missing. I have added them.

I also changed the order of the wallets in order to reflect better that the default choice for beginners is MultiBit rather than BitcoinQt. It is also more consistent with the upper part of the page.

Barthelemy added some commits Nov 24, 2013

Removed useless weird looking dot (.)
It is necessary to keep the div though in order to have the white
background span all the way down below the wallets images.
Contributor

schildbach commented Nov 24, 2013

The names are missing for a reason. They only appear after you have read the warnings that are associated with them.

Ok, I didn't know. I must say it looks weird. Would it be ok to keep the name ? People would anyways have to click on "I understand" before accessing the website.

Contributor

saivann commented Nov 24, 2013

@Barthelemy Did you test if removing the dot still works on IE6-7-8? It was a ugly workaround for some old browser IIRC. As for the names, I think we shouldn't change it. Asking for people to click "I understand" before accessing the website wouldn't be contextual; the warning disclaimer is not the same for each wallet.

@saivann I will test on IE6-7-8 tomorrow. If it breaks, I will add back the dot and add a comment to explain why there is this dot.
As for the names, all I am proposing is that there is the name below the icons, no other changes. The disclaimers would remain exactly the same. It would simply remove the feeling that the page is unfinished which is given both by the dot and the mixture of icons+text and icons only. This was actually a remark about this page that was made to me by someone who came to bitcoin.org as a complete beginner.

Contributor

saivann commented Nov 24, 2013

@Barthelemy Thanks! Perhaps that it is possible to use some kind of hidden character instead of the dot, I don't know.. But IIRC, a break line didn't work. I agree that hidding the names isn't very intuitive, but like @schildbach said, they're hidden for a reason. I also thought about that previously, but that somehow defeats the purpose of requiring the user to read the disclaimer before being able to access the wallet. I might be wrong, but I think this change would be too controversial considering previous discussions about web wallets.

If I understand correctly, some names are hidden in order to prevent the users to google them before they have read the warning ?
In my opinion it doesn't really make sense, or maybe I misunderstood something.
Just to be clear, I understand what the problem is of giving people links to web wallets or third party wallets. Here I am questioning the design of the page. Forcing the users to read a disclaimer and to click on a button before they can access the link is enough. We don't need to hide part of the information, i.e. the name of the tool while keeping its icon. We would achieve the same (user is aware of the risk) by putting the names, but the page would suddenly look like it has been properly rendered.

Contributor

saivann commented Nov 24, 2013

@Barthelemy OK you might not need to test IE, I just figured that the "dot workaround" is necessary for all browsers to prevent floating divs to overflow outside of the page. Other better workarounds exist but they don't work for IE6, which is still supported for Chinese users. However, I just tested
(break line) with all browsers and it worked, so it might be better to replace the dot with that and add a comment as you suggested.

As for the wallet, yes, you understand it correctly. It's both about preventing the user to think they are "all secured the same way" and preventing the user to google them without seeing the disclaimer. Sure, that design isn't super-consistent, but I'd prefer having them this way than crossing a line and having them removed from bitcoin.org, because there's probably many people ready to ask them to be dropped if they are promoted this way.

Ok, so it is good that the break line works.

Fine for the design, I see I won't convince you :)

Contributor

saivann commented Nov 28, 2013

@Barthelemy Can you overwrite your branch?

@saivann saivann closed this in d83361b Dec 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment