Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add missing wallets names, and changed order of wallets #274
Conversation
added some commits
Nov 24, 2013
|
The names are missing for a reason. They only appear after you have read the warnings that are associated with them. |
Barthelemy
commented
Nov 24, 2013
|
Ok, I didn't know. I must say it looks weird. Would it be ok to keep the name ? People would anyways have to click on "I understand" before accessing the website. |
|
@Barthelemy Did you test if removing the dot still works on IE6-7-8? It was a ugly workaround for some old browser IIRC. As for the names, I think we shouldn't change it. Asking for people to click "I understand" before accessing the website wouldn't be contextual; the warning disclaimer is not the same for each wallet. |
Barthelemy
commented
Nov 24, 2013
|
@saivann I will test on IE6-7-8 tomorrow. If it breaks, I will add back the dot and add a comment to explain why there is this dot. |
|
@Barthelemy Thanks! Perhaps that it is possible to use some kind of hidden character instead of the dot, I don't know.. But IIRC, a break line didn't work. I agree that hidding the names isn't very intuitive, but like @schildbach said, they're hidden for a reason. I also thought about that previously, but that somehow defeats the purpose of requiring the user to read the disclaimer before being able to access the wallet. I might be wrong, but I think this change would be too controversial considering previous discussions about web wallets. |
Barthelemy
commented
Nov 24, 2013
|
If I understand correctly, some names are hidden in order to prevent the users to google them before they have read the warning ? |
|
@Barthelemy OK you might not need to test IE, I just figured that the "dot workaround" is necessary for all browsers to prevent floating divs to overflow outside of the page. Other better workarounds exist but they don't work for IE6, which is still supported for Chinese users. However, I just tested As for the wallet, yes, you understand it correctly. It's both about preventing the user to think they are "all secured the same way" and preventing the user to google them without seeing the disclaimer. Sure, that design isn't super-consistent, but I'd prefer having them this way than crossing a line and having them removed from bitcoin.org, because there's probably many people ready to ask them to be dropped if they are promoted this way. |
Barthelemy
commented
Nov 24, 2013
|
Ok, so it is good that the break line works. Fine for the design, I see I won't convince you :) |
|
@Barthelemy Can you overwrite your branch? |
Barthelemy commentedNov 24, 2013
I noticed that the names of the wallets at the bottom of the page "choose your wallet" were missing. I have added them.
I also changed the order of the wallets in order to reflect better that the default choice for beginners is MultiBit rather than BitcoinQt. It is also more consistent with the upper part of the page.