Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Added visual separator between wallet types on choose-your-wallet page #307
Conversation
schildbach
commented on b27b013
Feb 5, 2014
|
LGTM |
saivann
closed this
in
fbaac9d
Feb 5, 2014
|
Thanks for your pull request. I have just merged your work with additional fixes and improvements for better compatibility with older IE versions and mobiles, and to keep a total 40px padding between wallet categories. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
lucb1e commentedFeb 4, 2014
It took me a minute to understand why blockchain.info's icon was on the "choose your wallet" page twice, and I also remember wondering whether it'd be clear to users that some downloads are not desktop applications. I only understood once I saw the text above the icons.
Since many people don't read the all the text on a page (especially a page leading to downloads, and I came here looking for the bitcoin-qt download), I think this visual hint, separating the different types with a gray line, makes it clearer that there is not only the choice of which wallet to use but also different types of wallets.
Screenshot of change (to compare with bitcoin.org/en/choose-your-wallet): http://i.imgur.com/PcCqIEO.png
I'm not that experienced with Github and how appropriate it is to do pull requests for such a small change, but I think it will help users so I'd like to contribute the change anyway. Thanks!