Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Display events on a map using OpenStreetMap #310

Merged
merged 1 commit into from Feb 9, 2014

Conversation

Projects
None yet
2 participants
Contributor

saivann commented Feb 8, 2014

Live preview: (merged)

This pull request adds a map for events based on OpenStreetMap and leaflet. No additional requirement is needed when adding new events; Google Geocoding API is used when building the website to get latitude and longitude for each event's city address.

Contributor

schildbach commented Feb 8, 2014

Nice!

Can we (maybe as a separate commit) be able to add exact coordinates to the events?

Contributor

saivann commented Feb 8, 2014

@schildbach Allowing users to optionally submit latitude & longitude in _events/* files would be quite simple. This said I'm not sure if we should display full address; users should visit events' websites so they can be informed if an event has been moved or canceled, buy tickets or subscribe if required, etc.

Contributor

schildbach commented Feb 8, 2014

@saivann Your argument is a point against showing a map at all. On the live preview linked above, you're showing an exact location but it's wrong.

Contributor

saivann commented Feb 9, 2014

@schildbach Good point, maybe it is not obvious that we're only pointing to the city. Given that we don't list opening hours, I guess that listing the full address is only good. I have just updated the pull request and live preview, does that look good to you?

Contributor

schildbach commented Feb 9, 2014

I verified that the geocoding for the two Berlin places works ok. Still I'd like to correct the address of c-base (the hackathon venue) to:

Rungestraße 20, 10179 Berlin

("Raumstation" is not part of the address, rather a subtitle of c-base)

Contributor

saivann commented Feb 9, 2014

@schildbach Fixed, thanks. I just added a seperate "venue" field for all events. I noticed that sending this information as part of the address sometime misleads the geolocating API.

saivann added a commit that referenced this pull request Feb 9, 2014

Merge pull request #310 from bitcoin/eventsmap
Display events on a map using OpenStreetMap

@saivann saivann merged commit 52f4aee into master Feb 9, 2014

@saivann saivann deleted the eventsmap branch Feb 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment