Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add BitGo wallet #337
Conversation
|
A webwallet is a webwallet regardless of where keys are stored. |
|
@luke-jr Sorry if that comment was confusing - this patch does classify it as a web wallet. I was just highlighting that it is a web wallet more like blockchain.info than coinbase. |
ghost
commented
Mar 24, 2014
|
@mbelshe Hi Mike, I've created an issue to gather comments on wallet inclusion criteria, it would be good to hear your thoughts. bitcoin#356 |
|
I'm all for this. I know Mike from his work at Google, I vouch for his technical competence and general legitimacy. BitGo is designed to not require your private keys, it's in fact not so much a wallet as a third party risk analysis service that happens to bundle a wallet because there aren't any others that support that feature right now. W.R.T. the auto-update issue, yes, this is a concern, however right now there are no wallet apps that use threshold signing for updates. A hacked developer could push a bad update for any of them. I have a plan to help address this, and it'd also apply to "web wallets" that root themselves in a Chrome extension, but I haven't done it yet. So whilst wallets that can get hacked and bad updates pushed are Bad News(tm), it's not something that should be a strike against BitGo because all wallets suffer the same issue. |
jgarzik
commented
Mar 27, 2014
|
ACK - BitGo is the first of the new, more secure wallets. I've seen a demo, and the author(s) are definitely clueful. Go for merge. |
|
@mbelshe Can you update your icon to a 144px icon in which your logo fits within 96px ? You can look at Bitcoin Core icon as an example: https://github.com/bitcoin/bitcoin.org/blob/master/img/clients/lo-bitcoin.png Additionally, I think if we keep the same warning disclaimer as hybrid / non-decentralized wallets, Bitgo should be listed alongside blockchain.info, before coinbase / coinkite. |
mbelshe
added some commits
Mar 27, 2014
|
Thanks everyone. @saivann - I updated the pull request with a logo as per your comment. Let me know if you need more. ty! |
|
LGTM @mbelshe Thanks for taking time to submit a properly formatted pull request and answering emails / comments. @gwb3 Can you import translations from this pull request on Transifex? |
mbelshe commentedMar 8, 2014
This change adds bitgo to the wallet list.
BitGo has been in operation for 6 months now without incident. BitGo operates similarly to blockchain.info in that the user holds the keys (e.g. bitgo is not a 'web wallet'), but Bitgo is different from blockchain.info in that wallets are P2SH/2-of-3 multisig. You can read about how it works in our whitepaper at https://bitgo.com/p2sh_safe_address). We've been helping the bitcoin community with open source patches for multi-sig work which have been accepted in bitcoinj (multibit and the android wallet), blockchain.info, and others. Our core bitcoin multisig work is all open source and has been used by several of the follow-on multi-sig web wallets that have released this year (bitcoinjs-lib). We have a full time staff supporting the wallet, and I believe is a good candidate for this list. Please let me know if you have any questions.