Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add clarification for running translation update script from web root. #343

Merged
merged 1 commit into from Mar 14, 2014

Conversation

Projects
None yet
2 participants
Contributor

wbnns commented Mar 13, 2014

Update text for additional clarity.

@saivann saivann and 1 other commented on an outdated diff Mar 13, 2014

README.md
@@ -28,7 +28,7 @@ Installing dependencies on older Ubuntu and Debian distributions
### Import translations
-**Update translations**: You can update the relevant language file in \_translations/ and run ./\_contrib/updatetx.rb to update layouts and templates for this language. You should also make sure that no url has been changed by translators. If one page has been replaced or moved, a redirection can be added in \_config.yml.
+**Update translations**: You can update the relevant language file in \_translations/ and from the web root run ./\_contrib/updatetx.rb to update layouts and templates for this language. You should also make sure that no url has been changed by translators. If one page has been replaced or moved, a redirection can be added in \_config.yml.
@saivann

saivann Mar 13, 2014

Contributor

How about "from the root of the git repository"? My impression is that "web root" could be misunderstood as "the root of the web server".

@wbnns

wbnns Mar 14, 2014

Contributor

@saivann - Thanks for the feedback! Done. ::thumbs up::

saivann added a commit that referenced this pull request Mar 14, 2014

Merge pull request #343 from gwb3/update-translation-script-instrux
Add clarification for running translation update script from web root.

@saivann saivann merged commit ba3929a into bitcoin-dot-org:master Mar 14, 2014

Contributor

saivann commented Mar 14, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment