Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add xapo wallet #388
Conversation
|
@baires Thanks for submitting a pull request. Usually, contributors are expected to provide the rationale for submitted changes and answer any question that might arise ( a description of the service, especially focused on how customer funds are secured, would be relevant here ). All online services storing keys for the user, in whole or in part, are currently listed under web wallet with a warning disclaimer. It is my understanding that xapo have complete control over users' private keys. If this is accurate, xapo should use the same disclaimer as Coinkite and Coinbase and be listed next to Coinkite. |
|
@saivann Thanks for the feedback I'm pushing the fix, sorry about that. |
|
@baires Can you introduce xapo a little bit more? As suggested earlier, perhaps provide a description of the service, especially focused on how customer funds are secured. Don't worry about the pull request formatting, I'll test it and help fixing small remaining glitches if it gets merged. |
|
@saivann Sorry about that I forgot the introduction about Xapo. Xapo is wallet that is innovating in the bitcoin space. We aim to solve the problem of security and convenience by providing insured cold storage and access to funds instantly with our wallet. BTW is was a lttle bit confusing the process of adding a new wallet, specially with this line (16) I just checked it on a mobile device and it seems that all the content inside it is always hidden. Any idea about that? |
|
@baires Can you elaborate on the following:
As I said, don't worry about the pull request formatting for now. I'll test it when I got a little more time, this is the kind of thing that can be fixed at the last minute. |
wikichaves
commented
Jul 16, 2014
|
Hi Saivann, here are the responses 1- You can send bitcoin to your vault (cold storage) from your wallet or straight to your Vault's address. the transaction is made immediately and just requires a 4-digit pin.
2- Yes we have that option, but not by default 3- The insurance is designed to cover incidents in which the user is not at fault. For example, attacks by hackers, theft by a Xapo employee, a break-in at the physical vault location, and our bankruptcy are all designed to be covered by the insurance. In these events, bitcoins lost by a user would be replaced by Xapo. More details here http://help.xapo.com/categories/6680-Insurance/questions 4- October 2013 thanks! |
|
@wikichaves @baires Thanks for your answers. Xapo seems to be working without incident since months and is providing at least equivalent security to other listed web wallets, as well as being one of the first insured wallets, so I think adding Xapo is reasonable at this point. There's significant changes that will probably be made to this page in the next week before this pull request is merged, I'll assist you with updating the branch in due time. |
wikichaves
commented
Jul 16, 2014
|
Thanks ! |
|
@baires @wikichaves Can you replace the commit in this pull request with the following? Icon: The icon can go in Screenshot: The screenshot can go in Description: You can add your description in _translations/en.yml exactly the same way as you previously did in this pull request. Layout and data: You can add the following after Coinkite in _templates/choose-your-wallet.html so your wallet is displayed with all relevant information.
|
wikichaves
commented
Jul 26, 2014
|
Sure, we will. Thanks !!!
|
|
@wikichaves I've found and fixed two mistakes in my last comment (icon image path and privacy score), just so you don't need to update the pull request twice. |
wikichaves
commented
Jul 26, 2014
|
Perfect, thanks :)
|
|
@saivann I just updated the PR, let me know is there anything else to do or fix. Thanks! |
saivann
commented on an outdated diff
Jul 28, 2014
|
@baires Your service's description is now missing in en.yml and needs to be added. Your icon is currently 100 X 100px, it should fit within 96 X 96px . Additionally (but that's not mandatory), it would be appreciated if you can put all of these changes in a single commit (no need to create another pull request, you can just overwrite this branch). |
|
@saivann I squashed the last commit and updated the logo |
|
@baires @wikichaves Thanks. Regarding your updated description I've just noticed a few possible typos, I can fix them but you're welcome updating your commit. s/bitcoin Wallet/Bitcoin wallet/
|
|
In the absence of critical feedback, this pull request will be merged on August 1th. |
wikichaves
commented
Jul 30, 2014
|
Thanks Saivan for doing this and fixing the typos :)
|
saivann
added a commit
that referenced
this pull request
Aug 1, 2014
saivann
merged commit 4f655cf
into
bitcoin-dot-org:master
Aug 1, 2014
wikichaves
commented
Aug 1, 2014
|
thanks !!! On Fri, Aug 1, 2014 at 10:48 AM, saivann notifications@github.com wrote:
|
baires commentedMay 5, 2014
This PR add xapo Wallet to the list of Desktop wallets.