Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add xapo wallet #388

Merged
merged 6 commits into from Aug 1, 2014

Conversation

Projects
None yet
3 participants
Contributor

baires commented May 5, 2014

This PR add xapo Wallet to the list of Desktop wallets.

Contributor

saivann commented May 7, 2014

@baires Thanks for submitting a pull request. Usually, contributors are expected to provide the rationale for submitted changes and answer any question that might arise ( a description of the service, especially focused on how customer funds are secured, would be relevant here ).

All online services storing keys for the user, in whole or in part, are currently listed under web wallet with a warning disclaimer. It is my understanding that xapo have complete control over users' private keys. If this is accurate, xapo should use the same disclaimer as Coinkite and Coinbase and be listed next to Coinkite.

Contributor

baires commented May 8, 2014

@saivann Thanks for the feedback I'm pushing the fix, sorry about that.
I just moved xapo to web wallets and added a disclaimer. Let me know is there is anything else to fix

Contributor

saivann commented May 8, 2014

@baires Can you introduce xapo a little bit more? As suggested earlier, perhaps provide a description of the service, especially focused on how customer funds are secured. Don't worry about the pull request formatting, I'll test it and help fixing small remaining glitches if it gets merged.

Contributor

baires commented May 8, 2014

@saivann Sorry about that I forgot the introduction about Xapo.

Xapo is wallet that is innovating in the bitcoin space. We aim to solve the problem of security and convenience by providing insured cold storage and access to funds instantly with our wallet.
Xapo raised a $20 million Series A round led by Benchmark a few weeks ago.

BTW is was a lttle bit confusing the process of adding a new wallet, specially with this line (16)
<div class="previewrow previewmobile" onclick="mobileWHover(event);">

I just checked it on a mobile device and it seems that all the content inside it is always hidden. Any idea about that?

Contributor

saivann commented May 8, 2014

@baires Can you elaborate on the following:

  • Describe the process of moving bitcoins in and out of cold storage?
    (Instant access to wallet and cold storage seems like opposite concepts, is there some delay, limits, verification process? In other words, what prevents someone's account from being emptied just by compromising a single password).
  • Do you enable two-factor authentication or similar security measures by default?
  • What exactly is covered by the insurance?
  • When did xapo entered in operation?

As I said, don't worry about the pull request formatting for now. I'll test it when I got a little more time, this is the kind of thing that can be fixed at the last minute.

Hi Saivann, here are the responses

1- You can send bitcoin to your vault (cold storage) from your wallet or straight to your Vault's address. the transaction is made immediately and just requires a 4-digit pin.
In order to retrieve, you need a longer and more secure process.

  • You only can send from your Vault to your Wallet
  • You need a vault password to retrieve
  • I takes between 12/24hs to process the retrieval.
  • You need to confirm your transaction by email
  • You can add a second factor authentication (optional)
  • You can cancel the transaction at any time (in that 12/24hs)

2- Yes we have that option, but not by default

3- The insurance is designed to cover incidents in which the user is not at fault. For example, attacks by hackers, theft by a Xapo employee, a break-in at the physical vault location, and our bankruptcy are all designed to be covered by the insurance. In these events, bitcoins lost by a user would be replaced by Xapo.

More details here http://help.xapo.com/categories/6680-Insurance/questions

4- October 2013

thanks!

Contributor

saivann commented Jul 16, 2014

@wikichaves @baires Thanks for your answers. Xapo seems to be working without incident since months and is providing at least equivalent security to other listed web wallets, as well as being one of the first insured wallets, so I think adding Xapo is reasonable at this point.

There's significant changes that will probably be made to this page in the next week before this pull request is merged, I'll assist you with updating the branch in due time.

Thanks !

Contributor

saivann commented Jul 26, 2014

@baires @wikichaves Can you replace the commit in this pull request with the following?

Icon: The icon can go in /img/clients/xapo.png . It must be a transparent 144 x 144px png, and your icon inside that transparent png should be centered and sized at 96 x 96px (see other icons as examples). Please optimize pngs with optipng -o7 file.png .

Screenshot: The screenshot can go in /img/screenshots/xapo.png and be sized at 250 x 350px . Please optimize pngs with optipng -o7 file.png .

Description: You can add your description in _translations/en.yml exactly the same way as you previously did in this pull request.

Layout and data: You can add the following after Coinkite in _templates/choose-your-wallet.html so your wallet is displayed with all relevant information.

- xapo:
    title: "Xapo"
    titleshort: "Xapo"
    compat: "web"
    level: 4
    platform:
      web:
        text: "walletxapo"
        link: "https://xapo.com/"
        screenshot: "xapo.png"
        os:
        check:
          control: "checkfailcontrolthirdpartyinsured"
          decentralization: "checkfaildecentralizecentralized"
          transparency: "checkfailtransparencyremote"
          environment: "checkfailenvironmentdesktop"
          privacy: "checkpassprivacybasic"
        privacycheck:
          privacyaddressreuse: "checkpassprivacyaddressrotation"
          privacydisclosure: "checkfailprivacydisclosureaccount"
          privacynetwork: "checkpassprivacynetworksupporttorproxy"

Sure, we will. Thanks !!!
On Jul 25, 2014 9:54 PM, "saivann" notifications@github.com wrote:

@baires https://github.com/Baires @wikichaves
https://github.com/wikichaves Can you replace the commit in this pull
request with the following?

Icon: The icon can go in /img/xapo.png . It must be a transparent 144 x
144px png, and your icon inside that transparent png should be centered and
sized at 96 x 96px (see other icons as examples). Please optimize pngs with optipng
-o7 file.png .

Screenshot: The screenshot can go in /img/screenshots/xapo.png and be
sized at 250 x 350px . Please optimize pngs with optipng -o7 file.png .

Description: You can add your description in _translations/en.yml
exactly the same way as you previously did in this pull request.

Layout and data: You can add the following after Coinkite in
_templates/choose-your-wallet.html so your wallet is displayed with all
relevant information.

  • xapo:
    title: "Xapo"
    titleshort: "Xapo"
    compat: "web"
    level: 4
    platform:
    web:
    text: "walletxapo"
    link: "https://xapo.com/"
    screenshot: "xapo.png"
    os:
    check:
    control: "checkfailcontrolthirdpartyinsured"
    decentralization: "checkfaildecentralizecentralized"
    transparency: "checkfailtransparencyremote"
    environment: "checkfailenvironmentdesktop"
    privacy: "checkfailprivacyweak"
    privacycheck:
    privacyaddressreuse: "checkfailprivacyaddressrotation"
    privacydisclosure: "checkfailprivacydisclosureaccount"
    privacynetwork: "checkpassprivacynetworksupporttorproxy"


Reply to this email directly or view it on GitHub
bitcoin#388 (comment).

Contributor

saivann commented Jul 26, 2014

@wikichaves I've found and fixed two mistakes in my last comment (icon image path and privacy score), just so you don't need to update the pull request twice.

Perfect, thanks :)
On Jul 26, 2014 9:39 AM, "saivann" notifications@github.com wrote:

@wikichaves https://github.com/wikichaves I've found and fixed two
mistakes in my last comment (icon image path and privacy score), just so
you don't need to update the pull request twice.


Reply to this email directly or view it on GitHub
bitcoin#388 (comment).

Contributor

baires commented Jul 28, 2014

@saivann I just updated the PR, let me know is there anything else to do or fix. Thanks!

@saivann saivann commented on an outdated diff Jul 28, 2014

_templates/choose-your-wallet.html
@@ -424,6 +424,29 @@
privacyaddressreuse: "checkpassprivacyaddressrotation"
privacydisclosure: "checkfailprivacydisclosureaccount"
privacynetwork: "checkpassprivacynetworksupporttorproxy"
+
@saivann

saivann Jul 28, 2014

Contributor

@baires Can you remove this space?

Contributor

saivann commented Jul 28, 2014

@baires Your service's description is now missing in en.yml and needs to be added. Your icon is currently 100 X 100px, it should fit within 96 X 96px . Additionally (but that's not mandatory), it would be appreciated if you can put all of these changes in a single commit (no need to create another pull request, you can just overwrite this branch).

Contributor

baires commented Jul 28, 2014

@saivann I squashed the last commit and updated the logo

Contributor

saivann commented Jul 30, 2014

@baires @wikichaves Thanks. Regarding your updated description I've just noticed a few possible typos, I can fix them but you're welcome updating your commit.

s/bitcoin Wallet/Bitcoin wallet/
s/storage Vault/storage vault/
s/spend bitcoin/spend bitcoins/

Xapo combines the convenience of an everyday Bitcoin wallet with the security
of a fully-insured deep cold storage vault. Xapo Debit Card links to your Xapo
Wallet and allows you to spend bitcoins at millions of merchants all around the world.
Contributor

saivann commented Jul 30, 2014

In the absence of critical feedback, this pull request will be merged on August 1th.

Thanks Saivan for doing this and fixing the typos :)
On Jul 29, 2014 6:35 PM, "saivann" notifications@github.com wrote:

In the absence of critical feedback, this pull request will be merged on
August 1th.


Reply to this email directly or view it on GitHub
bitcoin#388 (comment).

saivann added a commit that referenced this pull request Aug 1, 2014

@saivann saivann merged commit 4f655cf into bitcoin-dot-org:master Aug 1, 2014

thanks !!!

On Fri, Aug 1, 2014 at 10:48 AM, saivann notifications@github.com wrote:

Merged #388 bitcoin#388.


Reply to this email directly or view it on GitHub
bitcoin#388 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment