Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added Swedish translation #389

Merged
merged 1 commit into from May 16, 2014

Conversation

Projects
None yet
4 participants
Contributor

buren commented May 7, 2014

Imported all translations made at Transifex (for nofaq strings).

If there is anything missing / wrong / odd etc. just let me know and I'll fix it promptly.

Contributor

saivann commented May 7, 2014

@buren Thanks! These translations are not reviewed so I'll contact you on Transifex to assist you with that process. Some changes to the base.yml layout will indeed be required to not display the FAQ until it's translated, but this can be easily fixed when translations are ready.

Contributor

saivann commented May 7, 2014

@buren Yes, actually I see that Indonesian translations already have the FAQ disabled, so all that is needed is to edit {% when 'id' %} to {% when 'id' or 'sv' %} on line 83, and drop the faq url (line 437 in sv.yml) so the FAQ page never gets generated.

Contributor

wbnns commented May 13, 2014

Anything I can do here to be of assistance w/ this?

Contributor

saivann commented May 13, 2014

@gwb3 Yes, testing / reviewing translations in this pull request and answering any questions @buren might have on Transifex is welcome. @buren already made a lot of typo fixes and these translations are generally looking good.

For the record, @buren is currently asking for more peer-reviews and is taking care of the pull request. I think as soon as he says these translations are ready, we can final-check them.

Contributor

buren commented May 14, 2014

I went over all swedish translations once more with spelling/grammar check to catch the last remaining typos, see c0f0b15.

I'd really like to have someone review all strings in its entirety, to look for inconsistencies etc. I'll reach out to the previous contributors/reviewers again.. After that I would feel confident that the translation is of good enough quality to release.

@gwb3, @saivann is it anything else that needs to be done, except reviewing, before we can release this?

Contributor

wbnns commented May 14, 2014

@buren Hi! Awesome, thanks for going over stuff again! :) Let me circle back with @saivann and we'll follow-up, here!!

Contributor

buren commented May 15, 2014

@gwb3, @saivann ready when you are :)

Contributor

wbnns commented May 16, 2014

LGTM.

Contributor

saivann commented May 16, 2014

@buren @gwb3 Thank you very much for your work on this. Looking forward to seeing the FAQ completed!

saivann added a commit that referenced this pull request May 16, 2014

Merge pull request #389 from buren/master
Added Swedish translation

@saivann saivann merged commit cd40599 into bitcoin-dot-org:master May 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment