Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Small Changes To Devel Doc Based On Comments #394

Merged
merged 2 commits into from May 11, 2014

Conversation

Projects
None yet
2 participants
Contributor

harding commented May 11, 2014

This pull request propose to merge into the branch for #393 several small changes based on feedback from @luke-jr and @mikehearn.

_includes/guide_transactions.md:

  • DOS expanded to "denial of service" to improve readability and avoid conflation with Disk Operating System. Change based on feedback from @luke-jr. Thanks!

_includes/guide_mining.md:

  • Dropped assertion that getblocktemplate can't reuse an established socket. Change based on feedback from @luke-jr. Thanks!

_includes/guide_contracts.md:

  • Dropped opening sentences to Contracts section, which were a holdover from when contracts was a subsection of Transactions. New opening sentence is now similar to the summary sentences which open all other sections. Change based on feedback from @mikehearn. Thanks!
  • Deleted USA-centric example from second paragraph and merged remaining parts of the first two paragraphs into a single opening paragraph with no example. Change based on feedback from @mikehearn. Thanks!
  • Removed mention of placeholder byte from multisig example. Change based on feedback from @mikehearn. Thanks!
Small Changes To Devel Doc Based On Comments By @luke-jr & @mikehearn
_includes/guide_transactions.md:

* DOS expanded to "denial of service" to improve readability and avoid
  conflation with Disk Operating System. Change based on feedback from
  @luke-jr. Thanks!

_includes/guide_mining.md:

* Dropped assertion that `getblocktemplate` can't reuse an established
  socket. Change based on feedback from @luke-jr. Thanks!

_includes/guide_contracts.md:

* Dropped opening sentences to Contracts section, which were a holdover
  from when contracts was a subsection of Transactions. New opening
  sentence is now similar to the summary sentences which open all other
  sections. Change based on feedback from @mikehearn. Thanks!

* Deleted USA-centric example from second paragraph and merged remaining
  parts of the first two paragraphs into a single opening paragraph with
  no example. Change based on feedback from @mikehearn. Thanks!

* Removed mention of placeholder byte from multisig example. Change
  based on feedback from @mikehearn. Thanks!

@harding harding referenced this pull request May 11, 2014

Merged

Add Developer Guide To Bitcoin.org #393

6 of 6 tasks complete
Remove Assertion That Pay-To-Pubkey (Unhashed) Still Used In Coinbase…
… Txes

_includes/guide_transactions.md:

* Assertions that pay-to-public-key (unhashed) was "used in all coinbase
  transactions" and "is more convenient" have been removed: the first
  statement because its provably untrue; the second because it's debatable
  (spending unhashed keys requires fewer bytes, so it might be more
  convenient).  Based on feedback from @TierNolan.  Thanks!

@harding harding changed the title from Small Changes To Devel Doc Based On Comments By @luke-jr & @mikehearn to Small Changes To Devel Doc Based On Comments May 11, 2014

Contributor

harding commented May 11, 2014

Added another small change to this pull, this one suggested by @TierNolan. See c59b8e0 and saivann#130 for details. Thanks!

Contributor

saivann commented May 11, 2014

@harding LGTM. Unless someone adds a comment until then, this pull request will be merged into the main pull request today at 18:00:00 +0000 .

harding added a commit that referenced this pull request May 11, 2014

Merge pull request #394 from harding/docsupdate1
Small Changes To Devel Doc Based On Comments

@harding harding merged commit 0db9d5a into bitcoin-dot-org:devel-docs May 11, 2014

@harding harding deleted the unknown repository branch May 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment