/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make Clearer The Benefits Of Hardened Keys And The Absence Of A Master PubKey #412

Merged
merged 1 commit into from May 21, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@harding @saivann
@harding
Contributor

harding commented May 20, 2014

HTML preview: http://dg0.dtrt.org/en/developer-guide#hardened-keys

As suggested by @gmaxwell (thanks!), I tried to make clearer the benefit of hardened keys:

  • Described hardened keys as a solution in the first sentence of the Hardened Keys subsection.
  • Reordered the text so that the problem is described before the solution, making the presence of a solution clearer.
  • Added a prefatory sentence to the description of the two key derivation formulas again describing the hardened formula as a solution.

As suggested by @vbuterin (thanks!), I added a paragraph describing that HD wallets don't use normal derivation on the master key so they don't have an effective master public key. (See end of the diff.)

This is a fairly large diff because of the reordering, but no new clauses were added besides those described above.
@harding
Make Clearer The Benefits Of Hardened Keys And The Absence Of A Maste… 
…r PubKey

As suggested by @gmaxwell (thanks!), I tried to make clearer the benefit
of hardened keys:

* Described hardened keys as a solution in the first sentence of the
  Hardened Keys subsection.

* Reordered the text so that the problem is described before the
  solution, making the presence of a solution clearer.

* Added a prefatory sentence to the description of the two key
  derivation formulas again describing the hardened formula as a
  solution.

As suggested by @vbuterin (thanks!), I added a paragraph describing that
HD wallets don't use normal derivation on the master key so they don't
have an effective master public key. (See end of the diff.)

This is a fairly large diff because of the reordering, but no new
clauses were added besides those described above.
This commit was signed with a verified signature.
@harding harding David A. Harding
GPG key ID: 4B29C30FF29EC4B7 Learn about signing commits
cb5b220
@saivann
Contributor

saivann commented May 21, 2014

@harding LGTM, I suggest you merge this before May 24th.

@harding harding merged commit cb5b220 into bitcoin-dot-org:devel-docs May 21, 2014

@harding harding deleted the harding:hd-ancestor-compromise branch Jun 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment