Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Several Corrections & Clarifications Suggested On IRC #415

Merged
merged 2 commits into from May 23, 2014

Conversation

Projects
None yet
3 participants
Contributor

harding commented May 22, 2014

Suggested by @cbeams:

_includes/ref_block_chain.md:

  • Mention that coinbase is the first transaction in a block.

Suggested by @gmaxwell:

_includes/ref_core_rpcs-abcdefg.md:

  • Mention that you need to unlock your wallet when you run out of keys in the keypool.
  • Remove erroneous assertion that txindex=1 would allow getreceivedbyaddress to check balances of addresses not belonging to this wallet.

_includes/ref_transactions.md:

  • Clarify that OP_RETURN scripts aren't usually executed because they always return false.

en/developer-reference.md

  • Add a warning about using block chain or mempool data in executable context.

Also Discussed

Not changed in this pull, but also discussed in IRC:

Several Corrections & Clarifications Suggested On IRC
**Suggested by @cbeams:**

_includes/ref_block_chain.md:

    * Mention that coinbase is the first transaction in a block.

**Suggested by @gmaxwell:**

_includes/ref_core_rpcs-abcdefg.md:

    * Mention that you need to unlock your wallet when you run out of
      keys in the keypool.

    * Remove erroneous assertion that txindex=1 would allow
      `getreceivedbyaddress` to check balances of addresses not
      belonging to this wallet.

_includes/ref_transactions.md:

    * Clarify that OP_RETURN scripts aren't usually executed because
      they always return false.

en/developer-reference.md

    * Add a warning about using block chain or mempool data in
      executable context.

@harding harding referenced this pull request in saivann/bitcoin.org May 22, 2014

Closed

Update definition of coinbase transaction #132

Contributor

saivann commented May 22, 2014

@harding I have just found another occurence where it might be useful to clarify that coinbase tx is the first one in a block, feel free to import this commit: 6c9cf4f

Otherwise, LGTM! Thanks!

Contributor

harding commented May 22, 2014

@saivann done. Thanks!

Contributor

harding commented May 22, 2014

Note: this pull will be merged into #393 around 23:59 UTC tonight unless critical feedback is received.

Contributor

cbeams commented May 22, 2014

LGTM, thanks Dave.

@harding harding merged commit 6c9cf4f into bitcoin-dot-org:devel-docs May 23, 2014

@harding harding deleted the harding:fixes-sundry branch Jun 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment