Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add a temporary BETA disclaimer in devel-docs #416
Conversation
|
LGTM. The only downside I see in my testing is that the warning can't be hidden when javascript is disabled. However, noscript users like myself are used to far worse artifacts, so this is fine by me. Thanks, @saivann! |
|
@harding Thanks! Yeah I also always like to provide graceful fallback for noscript users, but I don't see any trick I could use in this case in which the disclaimer would still be visible. |
saivann
added a commit
that referenced
this pull request
May 23, 2014
saivann
merged commit 090c5df
into
devel-docs
May 23, 2014
saivann
deleted the
devel-docs-disclaimer branch
May 23, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
saivann commentedMay 22, 2014
Live preview: (merged)
This pull req adds a temporary disclaimer in devel-guide and devel-ref, mentioning that the documentation is in BETA. Along with the "Report an issue" button in the toc, I think these are reasonable measures to let us publish this documentation while it is partially reviewed by core developers.
The disclaimer is fixed-positioned so it appears even when people click on anchors, and it can be closed until the browser session ends (thanks @harding for the idea).