Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Display language menu in ordered columns #419
Conversation
|
@saivann - great change, LGTM. |
|
@saivann it is indeed a great change. LGTM too. |
|
@harding @gwb3 Thanks for your review! Merging this.. |
saivann
added a commit
that referenced
this pull request
May 24, 2014
saivann
merged commit d1bccc9
into
master
May 24, 2014
saivann
deleted the
newlangbar branch
May 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
saivann commentedMay 23, 2014
Live preview: (merged)
We are beginning to have too much languages for the current menu!
By using liquid {% cycle %} tag and pre-ordered language list in _config.yml, it is possible to display them in a "table-like" layout, which should be more scalable. The mobile menu shouldn't change.
I tested the new layout with IE6-10, as well as old and recent FF, OP, SA and chrome versions.