Add Hive Android to wallet page

[javgh]

Greetings from Hive!

We had our Mac OS X wallet listed for a while now on the wallet page. This pull request renames the listing from just "Hive" to "Hive OSX", to clarify, that this refers to our Mac product.

In a second commit, it adds a listing for our Android wallet, which we launched a week ago and targets mobile users.

Hive Android is a fork of the Schildbach wallet, so it is based on a fairly mature codebase. You can find a review by Coindesk here http://www.coindesk.com/hive-launches-android-bitcoin-wallet-built-app-store/ and see user ratings in the Google Play store here https://play.google.com/store/apps/details?id=com.hivewallet.androidclient.wallet .

I hope, this pull request can be merged. Please let me know, if you have any questions or want me to change anything. Thanks!

[saivann]

Can you revert this change here and in _translations/*? Although it might not be perfect, this is really just an ID so it's not really an issue if it isn't perfectly representing the string. However, changing it would cause loss of translations, reviews and history, and some extra work, so it's probably better to just leave this untouched.

[javgh]

Ok, sure, makes sense! I just rebased it with the original string identifier left untouched.

[saivann]

Commit LGTM now.

@javgh If I understand correctly, the app was released two weeks ago? I remember that we waited for the OS X app to exit BETA in the past before publishing it and according to your website, the Android app is still in BETA. Perhaps we could wait another 2 weeks to see if everything's working good?

[javgh]

That's right. That's why I mentioned, that it is a fork of the Schildbach codebase. There is of course always the risk of introducing bugs, but I think our changes are mostly UI-related, so I would consider it fairly low-risk. It's not 'beta' in the sense, that a brand-new wallet would be. But the decision is up to you. If you think it's better to wait a few weeks, I can understand that!

[saivann]

@javgh Thanks for your answer. Let's allocate one week to at least give people some time to comment if needed, otherwise this LGTM.

In the absence of critical feedback, this pull request will be merged on June 1th .

[schildbach]

I think we agreed some time ago that each wallet should be listed only once to prevent overcrowding the page. We even removed pre-existing duplicates like bc.i.

[saivann]

@schildbach Yeah, this bothers me a little too, but @javgh had the good idea to rename Hive to "Hive OSX" and "Hive Android". In this case it isn't the same wallet on multiple device, it's two different wallets by the same team, which isn't likely to happen to all Desktop wallets, as opposed to web wallets which are available on all platform by design.

[schildbach]

@saivann I think it's too easy to just rename the app to circumvent the convention. In the end, it's the same app, just different platforms.

[saivann]

@schildbach The reason I think it's acceptable isn't the name, but the wallet being a separate wallet. As far as I'm concerned, I think web wallets should be listed once because they would otherwise be duplicated everywhere. Hive isn't a web wallet, and it seems unlikely to me that other desktop wallets will provide mobile wallets, so I didn't see this becoming an issue in the foreseable future.

[schildbach]

Electrum has had an Android version since ages and we could have included it separately, but decided against it. To be fair, the Android version is not really usable by anyone except hardcore users, due to the painful install process.

[javgh]

What's the verdict now?

Andreas, I can understand your reservations regarding having the Hive logo displayed twice. I think it hints at the fact, that the wallet page will probably need to be reworked completely at some point, seeing as there will probably be more and more wallet providers. If each company is to be only listed once, then Hive, as a wallet maker, already doesn't fit into just one of the existing categories of "desktop", "mobile" and "web".

But unless that complete overall is done right now, I think it's reasonable to have both Hive wallets listed here. They are different codebases, target different platforms, target different form factors (desktop vs mobile) and have different names (Hive OSX vs Hive Android). They only share the Hive umbrella brand.

[schildbach]

As an alternative, you could mention in Hive's description that it is also available as a mobile app, like I mentioned the BlackBerry version of Bitcoin Wallet in its description.

Then again, I don't want to be too stubborn about it. Just wanted to voice my concerns about too many entries for basically the same app. I respect the majority vote on this.

[saivann]

@schildbach I didn't want to merge this without checking if this really bothers you. FWIW, I think the real issue was web wallets, and duplicating Hive isn't an argument for duplicating them again. But I'm still thinking about many major improvements for this page regardless.

@javgh There is a merge conflict, can you update your commits?

[javgh]

@saivann: Commits updated!

[javgh]

Commits updated again - changed spelling from "Hive OSX" to "Hive OS X".

[saivann]

In the absence of critical feedback, this pull request will be merged on June 5th.