Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Provide "GitHub-like" anchor links affordance #426

Merged
merged 2 commits into from May 26, 2014

Conversation

Projects
None yet
3 participants
Contributor

saivann commented May 25, 2014

Live preview: http://bitcoindevtest2.us.to/en/developer-guide

Yet another good idea from @cbeam. This pull request adds anchor link icons for all titles on devel-guide and devel-ref, which appear appear on mouse :hover similarly to READMEs or Wikis hosted on GitHub. This is achieved with some javascript code that automatically inserts the appropriate HTML inside all titles with an id.

I've reused a previous icon. Just let me know if you think we should really use something similar to GitHub (chain icons seemed a little bit hard to make with inkscape so I gave up at the first try).

@saivann saivann changed the title from Provide "GitHub-like" anchor links affordance (thanks @cbeams) to Provide "GitHub-like" anchor links affordance May 25, 2014

Contributor

harding commented May 25, 2014

I like it! LGTM. The icon you used is fine by me. Thanks!

Contributor

cbeams commented May 25, 2014

Cool, great to see! One thing though, the icon doesn't render terribly well on a retina display. It's not broken, but is noticeably pixelated.

Contributor

saivann commented May 25, 2014

@cbeams Thanks! Does it look better now?

Contributor

cbeams commented May 25, 2014

@cbeams Thanks! Does it look better now?

It does, thanks. LGTM now.

Contributor

saivann commented May 25, 2014

@harding @cbeams Thanks!

In the absence of critical feedback, this pull request will be merged on May 26th.

saivann added a commit that referenced this pull request May 26, 2014

Merge pull request #426 from bitcoin/devel-anchors
Provide "GitHub-like" anchor links affordance

@saivann saivann merged commit cc03f39 into master May 26, 2014

@saivann saivann deleted the devel-anchors branch May 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment