/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Describe Uncompressed And Compressed Public Keys #447

Merged
merged 2 commits into from Jun 13, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@harding @saivann
@harding
Contributor

harding commented Jun 10, 2014

Preview: http://dg3.dtrt.org/en/developer-guide#public-key-formats

A quick little subsection the two different public key formats possible in Bitcoin. Thanks to @sipa for inspiration on graphing the secp256k1 curve. (I plan to replicate his nice prime field illustration someday.)

Note: diff went a bit crazy on the reordered base58 private key list. I just added a new item and reordered the subsequent items.

harding added some commits Jun 10, 2014

@harding
Describe Uncompressed And Compressed Public Keys 
A quick little subsection the two different public key formats possible
in Bitcoin.
This commit was signed with a verified signature.
@harding harding David A. Harding
GPG key ID: 4B29C30FF29EC4B7 Learn about signing commits
968d9c1
@harding
Updates To Compressed Keys Based On Reviewer Feedback 
Several reviewers kindly provided feedback via IRC tonight, resulting in
the following changes:

* Mention that compressed keys are used in the offical secp256k1
  documentation with the prefix bytes used by Bitcoin. I could not find
  a publicly-available officialish document defining the prefix bytes,
  but they're used repeatedly in the offical SECG documentation we
  autoxref "secp256k1" to, so I went with that.

* Remove the mention that Bitcoin Core uses OpenSSL. While true, there
  is an effort to slowly move away from using OpenSSL for EC in
  Bitcoin Core.

* Change the phrasing of the relative curve location for 0x02 & 0x03 to
  a form more correct for actuality instead of the illustrated
  abstraction.

* Drop quotes around "uncompressed" since that's the term used in the
  official secp256k1 docs, not something Bitcoin-specific.
This commit was signed with a verified signature.
@harding harding David A. Harding
GPG key ID: 4B29C30FF29EC4B7 Learn about signing commits
8a9abff
@harding
Contributor

harding commented Jun 12, 2014

Several reviewers on IRC tonight kindly reviewed this PR. Commit 8a9abff describes the changes made as a result of that feedback. I thank all of them for their help and kind words.

If no critical feedback is received, I will merge this sometime after 04:00 UTC Friday.
@saivann
Contributor

saivann commented Jun 13, 2014

@harding Thanks for taking feedback and being careful to produce the best quality documentation as possible!

@harding harding merged commit 8a9abff into bitcoin-dot-org:master Jun 13, 2014

@harding harding deleted the harding:compressed-keys branch Feb 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment