Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add Warning About Handling Private Keys To Transaction Examples #450

Merged
merged 2 commits into from Jun 11, 2014

Conversation

Projects
None yet
2 participants
Contributor

harding commented Jun 11, 2014

(As an embarrassing footnote, the only time I ever handled private keys on mainnet, I lost $4.00 worth of bitcoins. Lesson learned.)

Contributor

saivann commented Jun 11, 2014

I also thought this code example could be sensitive if used directly, good idea! Maybe we can shorten it a little and also display it in the P2SH example, since it is also using dumprivkey?

**Warning:** Users should never manually manage private keys on mainnet.
Making a mistake with a private key can be very costly---as in the case of a HD
wallet [cross-generational key compromise][devguide hardened keys].
These examples are to help you learn, not for you to emulate on
mainnet.
Contributor

harding commented Jun 11, 2014

@saivann I liked how the previous phrasing re-enforced the idea that raw txes are unsafe.

I agree that we should add another warning to the P2SH section. How about we keep the original warning in the Complex section and add a shorter warning with a link in the P2SH section? E.g.

Reminder: Users should never manually manage private keys on mainnet. See the warning in the [complex raw transaction section][devex complex raw transaction].

Contributor

saivann commented Jun 11, 2014

@harding LGTM

Contributor

harding commented Jun 11, 2014

@saivann done in commit 85f2709. Thanks! (If it LGT you, I think its good to merge. I tested the new links.)

saivann added a commit that referenced this pull request Jun 11, 2014

Merge pull request #450 from harding/nevertouchprivkeys
Add Warning About Handling Private Keys To Transaction Examples

@saivann saivann merged commit 1db4eb4 into bitcoin-dot-org:master Jun 11, 2014

Contributor

saivann commented Jun 11, 2014

@harding Thanks!

@harding harding deleted the harding:nevertouchprivkeys branch Feb 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment