Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add Warning About Handling Private Keys To Transaction Examples #450
Conversation
|
I also thought this code example could be sensitive if used directly, good idea! Maybe we can shorten it a little and also display it in the P2SH example, since it is also using dumprivkey?
|
|
@saivann I liked how the previous phrasing re-enforced the idea that raw txes are unsafe. I agree that we should add another warning to the P2SH section. How about we keep the original warning in the Complex section and add a shorter warning with a link in the P2SH section? E.g.
|
|
@harding LGTM |
saivann
added a commit
that referenced
this pull request
Jun 11, 2014
saivann
merged commit 1db4eb4
into
bitcoin-dot-org:master
Jun 11, 2014
|
@harding Thanks! |
harding commentedJun 11, 2014
(As an embarrassing footnote, the only time I ever handled private keys on mainnet, I lost $4.00 worth of bitcoins. Lesson learned.)