Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Make translate.rb plugin fallback to English by default #458
Conversation
|
In the absence of critical feedback, this pull request will be merged on June 17th. |
saivann
added a commit
that referenced
this pull request
Jun 17, 2014
saivann
merged commit 5888dbb
into
master
Jun 17, 2014
saivann
deleted the
translationfallback branch
Jun 17, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
saivann commentedJun 16, 2014
Live preview: (Merged)
This pull requests allows {% translate %} to return the English string if no translated string is available. This can simplify updating translations and layouts in some cases.
This pull req also displays more English strings in outdated translations (e.g. some important texts still missing for some languages). This allows to reduce the number of "language-specific" content in templates and reduce the complexity of adding new content in some cases. Although displaying English strings in translations is not ideal, it appears better to me in some cases than serving incomplete content.