Add list of bitcoin.org contributors

[saivann]

Live preview: (Merged)

This pull requests is adding a list of contributors to bitcoin.org in the "About bitcoin.org" page, both an hardcoded list and another one using GitHub API. This list is far from complete (I've only started asking people if they want credits here since a few months), but at least we would now have a dedicated place for this purpose.

[harding]

@saivann looks nice. Thanks!

[instagibbs]

LGTM!

[saivann]

@harding @instagibbs Thanks!
In the absence of critical feedback, this pull request will be merged on June 17th.

[laanwj]

Looks great

[schildbach]

I wonder how the GitHub list is generated. I contributed to bitcoin.org at least once, but I'm not on the list.

[saivann]

@schildbach I don't know why some contributors seem to be ignored by the GitHub API, the same is happening to Satoshi actually in the development page.

Just look at the API call and you'll notice you're missing:
https://api.github.com/repos/bitcoin/bitcoin.org/contributors?page=1&per_page=100

[schildbach]

Yeah, this seems to be a bug of GitHub. I just checked "git log | grep Schildbach" and there should be 15 contributions (some of them are really minor, but still GitHub should count them).

[harding]

It looks like it's ignoring users without an email address or website listed on their GitHub page (e.g. @schildbach), or who don't have a GitHub page (e.g. @s_nakamoto). I don't know whether it's a bug or a privacy reason it ignores users without a listed email/website.

[schildbach]

I checked my emails registered with GitHub earlier today, and indeed my git commit email wasn't in there. I added it and now I'm included with the API call (with some hours of delay though, probably caused by caching). The strange thing is GitHub has always detected my contributions, for example in these charts. Anyway, the problem is solved for me. Thanks!

[schildbach]

Will you rebuild the page before merging?

[harding]

@schildbach the page is automatically rebuilt after each addition to master. I just did a test build here and "schildbach (14)" appears as expected, so it should appear on the live site 10-15 minutes after the merge.

[harding]

@saivann looking at the contributors list, I notice that some of the longer names are cut off---including yours and Wladimir's. (In Iceweasel [FF] 17, your name is fine but Wladimir's is still cut off; in Chromium [Chrome] 28, only Wladimir's is cut off.)

The same problem is present on the en/development page with Wladimir's name and a few other names. Maybe we could decrease the number of columns by one to give each name a bit more space?

[saivann]

@harding @schildbach Thanks for debugging the GitHub issue!

@harding Agreed on your last suggestion, I just pushed a commit on master, that looks better!