Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Grammar fixes + security note #474
Conversation
zw
added some commits
Jul 17, 2014
|
@zw some good grammar catches here. Thanks! I'm curious why you changed some sentences into active sentences but left the rest as passive sentences? I'm all in favor of active sentences, but I think I like consistency more. As for Electrum, I had a similar thought, but Electrum clients place the same trust in Electrum servers as SPV clients place in full nodes, so I think the current description is reasonable. That doesn't mean it couldn't be improved, maybe by adding a new option that says, "connects to the Bitcoin network [through a proxy]" or something. @saivann grammatically, the changes here LGTM. Changing different than to different from is a shift from American common usage to British common usage, but nobody but grammarians in any English-speaking country really cares. :-) |
|
Unless @zw wants to make some last minute changes according to @harding's feedback, this all LGTM too, thanks! Regarding Electrum, @mikehearn recently pointed out that the the app is selecting random servers from an hardcoded list. This clearly isn't as good as being fully P2P, but yet still much better than using a single central server controlled by the developers of the app (e.g. mycelium, blockchain.info). So previous disclaimers for this wallets were dropped (see Mycelium VS Electrum on the current page https://bitcoin.org/en/choose-your-wallet). |
zw commentedJul 17, 2014
I think it's important to mention the issue with Blockchain.info wallet backup e-mails --- folks need to realise that they must extend good security to their e-mail accounts, and not doing so has been the cause of a few thefts in the past --- but it's a bit of a struggle to keep the text appropriately brief.
Also, couldn't find the right place to edit it and even if I could I'm uncertain, but I thought Electrum would be more appropriately described with checkfaildecentralizecentralizedtxt than checkpassdecentralizespvtxt since Electrum's network is not the same as the Bitcoin one. Worth checking with someone who understands Electrum better.