Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Update Hive icon and add Hive Web to the list of wallets #496
Conversation
|
@javgh Adding the web wallet will affect the position of your OSX and Android wallets. You'll need to move your wallet right before mycelium in the list, and use The icon needs to be resized to fit within 96 X 96px inside the 144px png. By reading about the general design of the service, I came accros this quote: "Client code (i.e. html, javascript, css) should be versioned, bundled and signed with a private key that we keep offline. The corresponding public key should be bundled with the distribution. The subsequent times when a user visits w.hivewallet.com, the client first checks the version of client bundle on server, if it is the same as it's own version there's nothing to do. If there is a newer version on server, the client uses the public key to verify the fingerprint of the newer version. If it matches, downloads and replaces itself. If not, it assumes that the server is compromised and does nothing." Did you find a way to implement such a signing scheme, or do you think you might suceed in the future? I think this is a very interesting idea and might deserve a dedicated text for the "Transparency" score. |
|
Aw, didn't realize how this level stuff works. Ok, I adjusted our position and level! Icon has also been changed, so that the inner part does not exceed 96px. That signing scheme is unfortunately not yet implemented, but it's definitely something we would like to do at some point, to get closer to native app security properties. |
|
Rebased against master. I split off the position change in the wallet list into its own commit, to make reviewing the new entry easier. But I can squash those again, if you like. |
javgh
referenced this pull request
in hivewallet/hivewallet.com
Aug 7, 2014
Closed
Send pull request for Hive Web to bitcoin.org "Choose your Wallet" page #27
|
LGTM. I haven't found concerning feedback from Hive users, the wallet seems pretty stable and the Hive team thus far seems to be doing a good job at developing and maintaining their wallets. In the absence of critical feedback, this pull request will be merged on August 10th. @javgh Feel free to do it or let me take care of it, but another merge conflict needs to be resolved. Your icon needs to be moved under wallets/hive.png and the picture needs to be cut to 96px instead of 144px, just removing useless extra transparent space in the picture. |
javgh
added some commits
Aug 2, 2014
|
Ok, great! I rebased again and incorporated those icon changes. |
|
@javgh Thanks! |
saivann
merged commit ca34ad6
into
bitcoin-dot-org:master
Aug 10, 2014
|
@javgh BTW your icon could be a little bigger, it doesn't take all available space within 96px. Feel free to submit an improved icon (couldn't find your SVG so I could take care of it). Please submit the icon against the latest commit on master, because icons have been moved and resized to 144px again. |
javgh commentedAug 2, 2014
As you might know, our HTML5 wallet Hive Web has now been out for a while and has generally been well received (see this Coindesk article, for example: http://www.coindesk.com/hive-web-wallet-bitcoin-adoption-roadblocks/ ).
We would therefore like to extend our wallet listing to the web section. This pull request contains a description for Hive Web, a screenshot and also changes the Hive icon to the latest version.
Security-wise Hive Web is similar to Blockchain.info, however the user's BIP32 passphrase never leaves their computer, so isn't stored on our servers in any way.
I hope this can be merged. Let me know if you have any questions or would like to see changes made. Thanks!