Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Retina icon for Bitcoin Wallet. #505
Conversation
|
@schildbach Great, thanks! |
saivann
added a commit
that referenced
this pull request
Aug 4, 2014
saivann
merged commit 033582a
into
bitcoin-dot-org:master
Aug 4, 2014
|
Does the 144px version actually make any difference? The website seems to force it to be scaled down anyway… |
|
@schildbach Yes, that makes a difference for retina displays. We're displaying a 144px picture within 72px, so retina displays can get the extra pixels from the picture. |
|
That's weird. How do you fit two pixels into one (or rather 4 into 1)? |
|
@schildbach My understanding is that normal displays just scale the picture, while retina displays have more pixels available on screen than the screen resolution, so they are actually using every pixels from the picture, even thought it's displayed as 72px. Edit: (That's the pixel ratio). |
schildbach
deleted the
schildbach:retina-icon-bitcoinwallet branch
Aug 4, 2014
|
I agree with @schildbach, that makes no sense. 72px is 72px. 144px is 144px. 144 != 72. |
|
@luke-jr Well, just see for yourself on a device with a higher pixel ratio :) The number of pixels on the screen != the number of pixels available from the screen resolution. Without this trick, pictures are blurry on retina displays or even just on my smartphone with a 1.5 pixel ratio. Edit (AFAIK, this workaround is very commonly used as most pictures aren't vector graphics) |
schildbach commentedAug 4, 2014
No description provided.