Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix platform names for iOS and BlackBerry OS. #507

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

schildbach commented Aug 6, 2014

No description provided.

Contributor

saivann commented Aug 6, 2014

Mmh, TBH, while your version is more accurate (not mixing device names with OS names), I think iPhone/BlackBerry is clearer to most people than iOS/BlackBerry OS. This change would apply in the menu, and people searching for iPhone apps wouldn't see it displayed in the menu.

Contributor

schildbach commented Aug 6, 2014

iPhone is not a platform. iOS is. The existing iOS wallets, are they not installable on iPads?

BlackBerry OS should actually be named BlackBerry OS 10 (or BB10), because that's the platform Bitcoin Wallet is targetted at. If you say BlackBerry alone you mean all those old BlackBerries that can't do apps.

Contributor

saivann commented Aug 6, 2014

@schildbach I think this would probably work fine if we are adding icons in the menu, so people who are unsure what iOS is can notice the Apple logo. I'm just unsure if the plain white Linux (tux) logo can look good at 16px, I will try this later today.

Contributor

schildbach commented Aug 6, 2014

Actually I think the mouseover for iOS was always "iOS", until 2 weeks ago. I never heard of any confusion. But sure, logos are always nice.

Contributor

saivann commented Aug 7, 2014

@schildbach Could we keep "BlackBerry"? I think it's obvious we're speaking of devices which can do apps. "BlackBerry OS" is pretty long under "iOS" and the resulting menu has a lot of white space (see screenshot below).

capture du 2014-08-07 13 26 34

Contributor

schildbach commented Aug 8, 2014

Sure we can. (-:

@saivann saivann closed this in af87086 Aug 8, 2014

Contributor

saivann commented Aug 8, 2014

@schildbach Thanks, I've just updated s/iphone/ios in the platform / icon names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment