Use a "Download" instead of "Visit website" for wallets apps on iTunes/Google Play/Chrome Store

[saivann]

Live preview: (Merged)

As suggested on #512, this pull request uses the "Download" button for all apps on iTunes/Google Play/Chrome Store and the "Visit website" for all other cases.

[saivann]

In the absence of critical feedback, this pull request will be merged on August 11th.

[harding]

LGTM. Thanks!

[schildbach]

LGTM, because "Download" is better than "Visit website" for apps that link to the app store.

(Even better for these cases would be "Install". App stores usually don't allow download of the application binary.)

Is it possible to combine the buttons, if desired? An app could have a download link and a link to its homepage at the same time.

[harding]

@schildbach I think the goal, as discussed #512, is to encourage users to install apps/browser extensions instead of just going to the website and starting to use the web wallet without installing the app/extension.

For an app like your wallet, where there is no web wallet, I think a homepage link would be nice. (Although I wonder if this would just make things more confusing for users. "Why does BW4A have links to Website, App, and Source when BC.i only has App and Source?")

[HostFat]

@schildbach @harding I still think that making these kind of choices (like hiding website links) over the people will isn't a good, I feel it also distant from common opinion of the Bitcoin environment...

[harding]

@HostFat It's definitely a trade-off. On one hand, these wallet providers have taken the time to create an app/wallet extension which enhances security over their pure web wallet; we want to reward that effort by giving them a higher security score. On the other hand, we suspect a lot of users won't choose to install that extension unless we encourage them, so we link to the extension rather than the web wallet.

If the web wallet publisher wants us to link directly to their homepage instead, I think that's a reasonable request---but we'd also lower their security score at the same time because we're no longer providing the encouragement to install the extension. This means the link choice is up to the wallet publisher, which seems fair to me. In this pull request, we're simply making it clear that we defaulted to the most secure choice.

[greenaddress]

@harding @saivann what is your take on multiple buttons? As @schildbach said it's another option.

As it stands it may be bloating to add more buttons but I'm far from being a designer so it may be possible to fit more buttons without degrading the UX.

If that's possible, it may be a reasonable compromise in terms of consistency but otherwise if everything is left as is I'm quite glad of the default security selection and relative rating.

[saivann]

@schildbach Re "Install": Right, that's more appropriate than "Download", I will push the update, thanks!

@greenaddress @schildbach Re third button: I think it cannot be added without always overflowing on the screenshot. And IMO, it would be more confusing / inconsistent than just linking to the app or website, and the "Source code" button is more important. In the end, the user just wants to read about the wallet and try it, and the extension as well as the website both serve that feature.

While I understand @HostFat opinion, I think we shouldn't let the perfect be the enemy of the good. As @harding said, any web wallet can request a change, or work on solutions, (e.g. requiring users to install the extension when using Chrome, signing remote code with local public key, etc.)

[schildbach]

For the Bitcoin Wallet case, I'd point
"Install" to the Google Play page,
"Download" to the APK download page (where you can also get older releases) and
"Source" to the GitHub page.
I think those three should fit on screen even if localized. Does this sound reasonable?

[saivann]

@schildbach I'd rather suggest you include a link in your text. Your APK download page isn't something most wallets will provide. We need a good right margin since text length can greatly vary between languages.

[schildbach]

I just went through the wallets in the first row: all except Hive have a separate download page. But I'm just suggesting. I can live without.

[saivann]

@schildbach All of them have one "Download" or "Visit website" link. Actually I think the ideal solution would be you should be creating a simple website with links to all platforms and old versions and we could be linking to it. Adding three buttons isn't very great I think.