Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Set closed-source score to blockchain.info #516
Conversation
saivann
added a commit
that referenced
this pull request
Aug 12, 2014
saivann
merged commit 6ee1fee
into
master
Aug 12, 2014
saivann
deleted the
blockchainandroidclosed branch
Aug 12, 2014
|
@zootreeves Blockchain.info's Android app nows gets a bad closed-source score. Feel free to open a pull request to revert this change when the updated source code will be available again. On a similar topic, I've noticed the recent denomination bug: FWIW, I seriously considered the idea of opening a pull request to remove blockchain.info from bitcoin.org due to the severity and concerning nature of this bug (and sudden lack of open-source code plus other concerning feedback didn't help). I really hope blockchain.info is taking serious steps to find out why this could happen and bug testing / app quality isn't decreasing. |
|
@saivann Apologies the Android app repo has been updated. The Denomination bug has been fixed in the latest iPhone version. |
|
@zootreeves Thanks. Any reason why the source code wasn't public for 20+ days? (Just want to make sure it will remain up to date). |
|
I checked the updated source repository, and it was restarted (again). This behaviour makes it very hard to review any changes and build trust in the codebase. @zootreeves can you say why are you doing this? |
saivann commentedAug 10, 2014
Updated source code for the Android wallet isn't available. There is strangely only a single "Initial commit" since 21 days, so Android users are using updated versions based on unpublished code.
https://github.com/blockchain/My-Wallet-Android
@zootreeves Please feel free to comment or fix the issue.
In the absence of critical feedback, this pull request will be merged on August 11th.