Add Hive iOS

[javgh]

Another pull request from the Hive people. ;-)

This one adds Hive iOS. Hive iOS is basically just Hive Web wrapped with Cordova to turn it into an app. So code-wise there isn't much new, although the design has been slightly adjusted to better match iOS. I hope this can be added to the iOS mobile category. Thanks!

[schildbach]

If the web page isn't open source, it should be
transparency: "checkfailtransparencyremote"

[saivann]

@javgh Could you use a single description both for Hive iOS and Hive Web in en.yml? Translating takes a lot of effort so this would be appreciated.

Under mobile:, can you use the Android app instead? Just for consistency with other wallets, which all show their Android app by default for the "Mobile" category.

I was also wondering if we should be using the checkfailtransparencynew score for Hive Web, Hive iOS and other wallets to be added in the following weeks, since these projects are relatively new.

[saivann]

@schildbach You probably mean "If the web page is loaded remotely"?

[javgh]

Ok, collapsed the descriptions to a single one for Hive Web and Hive iOS.

Also displayed Android as the default for mobile: . I'm not sure if that default view should list both Android and iOS platform as supported. It seems that otherwise you wouldn't necessarily discover, that there is also an iOS Hive product, but then again, it's somewhat different from Hive Android, so showing the iOS symbol next to a Hive Android screenshot seems confusing. So now the default view only shows Android as platform and then hopefully visitors will specifically filter down to iOS.

Hive iOS does not load any code from a remote server, the HTML and Javascript is already packaged and comes with the app. So I don't think that checkfailtransparencyremote applies.

[saivann]

If the code is part of the app and not loaded remotely, that's indeed how I see it too.

[schildbach]

@javgh Ah ok, didn't know that. So it only runs locally and all of the app code, html and javascript is open source (and versioned in your git repo)?

[javgh]

@schildbach That's right. The Hive Web source code can be found in this repository and the Hive iOS repository is a fork of that with Cordova build instructions added and some iOS tweaks applied and is located here: https://github.com/hivewallet/hive-ios . Both projects use a GPL license.

[saivann]

LGTM. In the absence of critical feedback, this pull request will be merged on August 21th.