breadwallet

[voisine]

Thank you for considering breadwallet for inclusion. I'm happy to address any question or concerns anyone has. Aside from breadwallet, I am co-author of BIP39 mnemonic seeds, and maintainer of BIP38 encrypted paper wallets.

[saivann]

@voisine Thanks for submitting your wallet. Can you fix the following?

Screenshot: This is good looking but this isn't a screenshot like other apps, can you provide one?

Icon: You're using a square icon, so it should fit within 85px instead of 96px.

Description: This appears to be the longest one, maybe you could make it more concise and remove HTML from it? For instance, is the reference to iOS relevant here, is your app making specific use of some of the OS security features? Shortening this would allow it to be fully displayed without being cut with a scrollbar in most language, and help reducing translation tasks and costs a little for volunteers.

Transparency score: New apps must use the checkfailtransparencynew score until at least 6 months has passed since the app and source code has been publicly released.

I haven't previewed the pull request yet. Feel free to overwrite your commits or not.

[voisine]

I am happy to make the requested changes, however, allow me to make some justifications first and you can tell me if they address the issues you mentioned.

The screenshot is an actual screen from the app launch. With such a small image it's difficult to convey the more detailed parts of the UI well. Is your concern about the screen chosen or the fact that the phone is included instead of just the bare shot?

I will remove the html from the description, however it is shorter than bitgo's description. Also, breadwallet does make specific use of all the relevant iOS security features which no other wallet does at present. My intention was to design something more secure than any other wallet out there. No javascript browser wrappers, no trusted servers, hardware AES encryption of all financial info, no private keys in memory except when signing via the iOS keychain. If you still feel I should shorten the description, I'll go ahead and do that.

The source code has been publicly available from the beginning of the project, longer than 6 months, and was functional and first built and used by other community members March 12, so just shy of 6 months ago. voisine/breadwallet#1

[saivann]

Regarding the screenshot, just like other apps, I think the most important point is to let the user have a first glimpse into what the app looks like.

Regarding the description, I think it's really up to you then.

Regarding the source code and score, to my understanding the app has been announced and launched in the iTunes Store 2 months ago. We've recently agreed to use the checkfailtransparencynew score for recent wallets on bitcoin.org. If everything goes well, the app will not keep this score for more than a few months.

[voisine]

Yes, it's been in the app store for 2 months, I was just angling for the most beneficial treatment I thought I might be able to get away with. :) I will make those changes. Thanks for your patience.

[voisine]

all fixed

[saivann]

@voisine Mmh, the screenshot still features some marketing text and a phone. It should only display what's on the actual GUI of the app (see other apps as an example).

[harding]

@voisine I notice you don't uppercase "breadwallet" in either the title or the description. Is this intentional? (Wallet names are proper nouns, and I think all of the other wallets uppercase their names.) If it's deliberate and you want your wallet's name lowercased, that seems fine to me.

Also in "bitcoin client" from the description, the Bitcoin should be uppercase according to the usual rule we use for this site (the Bitcoin protocol is a proper noun; bitcoin currency units are common nouns). Thanks!

[voisine]

@harding yes, breadwallet is lowercased in keeping with the lower case stroke b for 'bits' that I've also adopted in the logo. I capitalized Bitcoin in the description and also updated the screenshot. Thanks for the correction.

[saivann]

@voisine @harding Thanks!

LGTM. So far I've seen a good amount of positive feedback about breadwallet and couldn't find anything concerning about it (but comments and questions are welcome if someone else did).

In the absence of critical feedback, this pull request will be merged on September 10th.

[harding]

@voisine thanks! (I too have only heard good things about breadwallet, so I'm happy to see it on the site.)