small changes to TREZOR texts, add Docker tooling

[prusnak]

No description provided.

[schildbach]

Can you remove the superlative? Otherwise, we'll soon end up with plenty of wallets which are of course the best, easiest and most secure in the entire universe.

[prusnak]

No, we won't. We already reached that state:

$ grep "highest level" _translations/en.yml | wc -l
6

[schildbach]

Then let's remove all superlatives at the same time.

[schildbach]

See #543.

[harding]

This sentence confuses me:

Unlike a cold storage (offline storage or paper wallet), TREZOR is also able to sign transactions.

I agree paper wallets can't sign transactions, but other offline wallets can sign transactions. (The Armory entry specifically mentions cold storage.) Also the phrase "a cold storage" would be more natural sounding as just "cold storage".

I agree with @schildbach about removing all superlatives. In this specific case, I think it makes extra sense---in the statement "highest level of security and convenience", I think a reasonable case can be made for Trezor's high security, but it's hard to argue that using a Trezor is highly convenient compared to the other listed wallets.

[prusnak]

The idea behind "highest level of security and convenience" is that up to now it was impossible to achieve this level of security without sacrificing convenience and vice-versa it was impossible to achieve this level of convenience without sacrificing security. Feel free to rephrase as you wish.

Why I created this pull request is because I was asked by Saïvann Carignan and he specifically said: "I think a few people are still waiting for Trezor to be added on bitcoin.org" and he also prepared the branch and first commit into it. It's really not my intention to get dragged into another Github discussion, especially if it's a commit to a non-master branch.

[schildbach]

Imho your explanation sounds much more believable: "up to now it was impossible to achieve this level of security without sacrificing convenience and vice-versa it was impossible to achieve this level of convenience without sacrificing security". Why don't you include something like this in your description? (Shorter, but you get the point)

[harding]

@prusnak although this is a pull into a non-master branch, I think we can use this pull request to determine the final text for the master branch.

I think the text changes being requested here are small; however, if you're unwilling to make them, maybe you would consider asking @saivann to choose the text for you. He's already written several of the other wallet descriptions.

[saivann]

@prusnak Thanks for providing the description and other small changes. Can you confirm if you wish to provide an updated description yourself or just let me or someone else suggest a different text? Beside some neutrality concerns with superlatives, I think feedback is directed at helping improving your description but in the end how you want your wallet to be described is mostly your choice.

[prusnak]

Could you please draft a text which is a combination of the text from the wiki (and in my original commit)
and the claim from the bitcoin#542 (comment)? I'll just check it and ack it afterwards. Thank you very much!

[saivann]

How about this? (Also tried to keep same sentences while reducing word count to fit on 6 lines)

TREZOR is a hardware wallet providing high level of security
without sacrificing convenience. Unlike cold storage, TREZOR
is able to sign transactions while connected to an online device.
That means spending bitcoins is secure even when using
a compromised computer.

[harding]

@saivann that sounds good to me.

[schildbach]

@saivann LGTM

[prusnak]

ACK

[saivann]

I have included the amended commit and opened pull req #545 for adding TREZOR. Thanks for all your feedback.

[prusnak]

thx!