Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove superlatives and exclusive phrases from wallet descriptions. #543

Merged
merged 1 commit into from Sep 10, 2014

Conversation

Projects
None yet
6 participants
Contributor

schildbach commented Sep 7, 2014

No description provided.

Contributor

harding commented Sep 7, 2014

@mbelshe, @wikichaves, and @LinusU : can you comment on the small changes, respectively, to the BitGo, Xapo, and KnC text? Are they acceptable to you?

The Bitcoin Core change looks good to me. Thanks, @schildbach!

Contributor

saivann commented Sep 7, 2014

LGTM

Contributor

LinusU commented Sep 8, 2014

To be fair we only say that we strive to be the easiest, not that we are, but it's no big deal for us. LGTM

good to me too. what do you mean with "exclusive phrases"

Contributor

schildbach commented Sep 8, 2014

@wikichaves I meant if you're saying something is best, you're excluding other things to be better or even just as good.

agree, but we are not using superlatives in this description "Xapo combines the convenience of an everyday Bitcoin wallet with the security of a fully-insured deep cold storage vault. Xapo Debit Card links to your Xapo Wallet and allows you to spend bitcoins at millions of merchants all around the world."

right ?

Contributor

schildbach commented Sep 8, 2014

I think "fully-insured" is a superlative, which I replaced by "insured" in this commit.

ok. thanks

Contributor

harding commented Sep 9, 2014

The only affected wallet publisher we haven't heard from is @mbelshe for BitGo. In the absence of any critical comments, I think we should schedule this for merge in about 24 hours---around 14:00 UTC Wednesday.

Contributor

saivann commented Sep 9, 2014

Agreed, thanks!

@saivann saivann merged commit 394ac75 into bitcoin-dot-org:master Sep 10, 2014

Contributor

mbelshe commented Sep 11, 2014

Oh sorry. I looked at this and it is fine.
Thanks for asking.

Mike
On Sep 9, 2014 6:46 AM, "David A. Harding" notifications@github.com wrote:

The only affected wallet publisher we haven't heard from is @mbelshe
https://github.com/mbelshe for BitGo. In the absence of any critical
comments, I think we should schedule this for merge in about 24
hours---around 14:00 UTC Wednesday.


Reply to this email directly or view it on GitHub
bitcoin#543 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment