Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Remove superlatives and exclusive phrases from wallet descriptions. #543
Conversation
schildbach
referenced this pull request
Sep 7, 2014
Closed
small changes to TREZOR texts, add Docker tooling #542
|
@mbelshe, @wikichaves, and @LinusU : can you comment on the small changes, respectively, to the BitGo, Xapo, and KnC text? Are they acceptable to you? The Bitcoin Core change looks good to me. Thanks, @schildbach! |
|
LGTM |
|
To be fair we only say that we strive to be the easiest, not that we are, but it's no big deal for us. LGTM |
wikichaves
commented
Sep 8, 2014
|
good to me too. what do you mean with "exclusive phrases" |
|
@wikichaves I meant if you're saying something is best, you're excluding other things to be better or even just as good. |
wikichaves
commented
Sep 8, 2014
|
agree, but we are not using superlatives in this description "Xapo combines the convenience of an everyday Bitcoin wallet with the security of a fully-insured deep cold storage vault. Xapo Debit Card links to your Xapo Wallet and allows you to spend bitcoins at millions of merchants all around the world." right ? |
|
I think "fully-insured" is a superlative, which I replaced by "insured" in this commit. |
wikichaves
commented
Sep 8, 2014
|
ok. thanks |
|
The only affected wallet publisher we haven't heard from is @mbelshe for BitGo. In the absence of any critical comments, I think we should schedule this for merge in about 24 hours---around 14:00 UTC Wednesday. |
|
Agreed, thanks! |
saivann
merged commit 394ac75
into
bitcoin-dot-org:master
Sep 10, 2014
|
Oh sorry. I looked at this and it is fine. Mike
|
schildbach commentedSep 7, 2014
No description provided.