/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix issues with overusing CSS :hover in the wallet page #548

Merged
merged 1 commit into from Sep 11, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@saivann @schildbach @harding
@saivann
Contributor

saivann commented Sep 10, 2014

Live preview: http://bitcointest2.us.to/en/choose-your-wallet

This pull request aims to fix issue #544

Wallets are only displayed on click when javascript is enabled (basic CSS compatibility is preserved)
(javascript applies a .nohover class on all wallets and then selectively add or remove this class with click and mouseout events)

Clicks in the menu now works for parents (Desktop/Mobile/Hardware/Web), so it's possible to lock selection to any platform, in such a way that accidental :hover on the menu will be reverted.
@saivann
Fix issues with overusing CSS :hover in the wallet page (thanks @schi… 
…ldbach @harding) (fixes #544)

Click to see wallets when javascript is enabled
Click to select (lock) any platform in the menu
1b71345

@saivann saivann referenced this pull request Sep 10, 2014

Closed

Hover issues on wallets page #544

@schildbach
Contributor

schildbach commented Sep 10, 2014

That feels much better! Thanks!
@harding
Contributor

harding commented Sep 10, 2014

I agree: much better. Thanks!
@saivann
Contributor

saivann commented Sep 10, 2014

Great! In the absence of critical feedback, this pull request will be merged on September 11th.

saivann added a commit that referenced this pull request Sep 11, 2014

@saivann
Merge pull request #548 from bitcoin/lesshover 
Fix issues with overusing CSS :hover in the wallet page
fcbe9cb

@saivann saivann merged commit fcbe9cb into master Sep 11, 2014

@saivann saivann deleted the lesshover branch Sep 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment