/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Updated news resources (Cointelegraph, BitNovosti, Coinspot) #575

Merged
merged 3 commits into from Sep 26, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@arvicco @saivann
@arvicco
Contributor

arvicco commented Sep 24, 2014

No description provided.

@saivann saivann commented on an outdated diff Sep 24, 2014

_translations/en.yml
@@ -481,6 +481,7 @@ en:
pagedesc: "Find useful websites and resources about Bitcoin."
useful: "Useful places"
linkwiki: "<a href=\"https://en.bitcoin.it/\">Bitcoin Wiki</a>"
+ linkcointelegraph: "<a href="http://cointelegraph.com/">CoinTelegraph</a>"
@saivann

saivann Sep 24, 2014

Contributor

@arvicco You must escape the double-quotes here otherwise the file will hit parsing errors.

linkcointelegraph: "<a href=\"http://cointelegraph.com/\">CoinTelegraph</a>"
@saivann
Contributor

saivann commented Sep 24, 2014

@arvicco If you have time for it, you could add the Russian and Spanish links in _translations/ru.yml and _translations/es.yml at the same time.
@arvicco
Contributor

arvicco commented Sep 24, 2014

Ah, thanks! I have limited experience with complex templates... I'll correct this now.
@saivann
Contributor

saivann commented Sep 24, 2014

LGTM! In the absence of critical feedback, this pull request will be merged on September 25th.

saivann added a commit that referenced this pull request Sep 26, 2014

@saivann
Merge pull request #575 from arvicco/master 
Updated news resources (Cointelegraph, BitNovosti, Coinspot)
9503efe

@saivann saivann merged commit 9503efe into bitcoin-dot-org:master Sep 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment