Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Update/fix block size limits #578
Conversation
saivann
commented on the diff
Sep 26, 2014
| @@ -19,8 +19,8 @@ As of version 2 blocks, each block consists of four root elements: | ||
| 2. A 4-byte unsigned integer indicating how many bytes follow until the | ||
| end of the block. Although this field would suggest maximum block | ||
| - sizes of 4 GiB, max block size is currently capped at 1 MiB and the | ||
| - default max block size (used by most miners) is 350 KiB (although | ||
| + sizes of 4 GiB, max block size is currently capped at 1 MB and the |
theymos
Contributor
|
|
This LGTM. Since this is a small patch and a correction, I'll merge it in momentarily. It'll appear on the website a few minutes after that. Thanks, @theymos! |
theymos commentedSep 26, 2014
Bitcoin limits are usually defined using decimal-friendly numbers of bytes. The block size is limited to 1 MB, not 1 MiB, for example. Also, the latest block size limit is 750 KB, not 350 KB.