Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update/fix block size limits #578

Merged
merged 1 commit into from Sep 26, 2014

Conversation

Projects
None yet
3 participants
Contributor

theymos commented Sep 26, 2014

Bitcoin limits are usually defined using decimal-friendly numbers of bytes. The block size is limited to 1 MB, not 1 MiB, for example. Also, the latest block size limit is 750 KB, not 350 KB.

Update/fix block size limits
Bitcoin limits are usually defined using decimal-friendly numbers of bytes. The block size is limited to 1 MB, not 1 MiB, for example. Also, the latest block size limit is 750 KB, not 350 KB.

@saivann saivann commented on the diff Sep 26, 2014

_includes/ref_block_chain.md
@@ -19,8 +19,8 @@ As of version 2 blocks, each block consists of four root elements:
2. A 4-byte unsigned integer indicating how many bytes follow until the
end of the block. Although this field would suggest maximum block
- sizes of 4 GiB, max block size is currently capped at 1 MiB and the
- default max block size (used by most miners) is 350 KiB (although
+ sizes of 4 GiB, max block size is currently capped at 1 MB and the
@saivann

saivann Sep 26, 2014

Contributor

@theymos If we use MB, you could also s/GiB/GB on the same line :)

@theymos

theymos Sep 26, 2014

Contributor

4 GiB = 4294967296 bytes, which is the correct maximum number of bytes that the block data structure can hold (actually it's off by 1 byte, but whatever). 4 GB = 4 billion bytes, which is not correct. Similarly, 1 MiB and 1 MB are different, but in this case MB is correct and MiB is incorrect.

Contributor

harding commented Sep 26, 2014

This LGTM. Since this is a small patch and a correction, I'll merge it in momentarily. It'll appear on the website a few minutes after that. Thanks, @theymos!

@harding harding merged commit 8490061 into bitcoin-dot-org:master Sep 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment