Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update Hive Android entry to reflect new Cordova-based app #609

Merged
merged 2 commits into from Oct 20, 2014

Conversation

Projects
None yet
2 participants
Contributor

javgh commented Oct 18, 2014

As you might remember, Hive iOS is a Cordova-based app, which basically wraps Hive Web into a native shell.

To have Hive work the same across all platforms, we are now switching Hive Android to the same mechanism. A Cordova-based app for Android has just been released on Google Play (under a new id) and we are retiring the previous SPV app.

This pull request reflects these changes. The entry for Android now points to https://play.google.com/store/apps/details?id=com.hivewallet.hive.cordova (the new Cordova-based app) and the screenshots and details about risks have been changed to match the Hive iOS entry.

I hope this can be merged soon. Let me know if you have any question - thanks!

Contributor

saivann commented Oct 18, 2014

LGTM

@javgh Can you delete now unused strings / screenshots?

  • Delete the Android screenshot in /img/screenshots
  • Rename the remaining screenshot to hivemobile.png in /img/screenshots and _templates/choose-your-wallet.html
  • Delete the wallethive-android string in _translations/en.yml
Contributor

javgh commented Oct 19, 2014

Good idea - I added another commit to clean up those things.

Contributor

saivann commented Oct 20, 2014

In the absence of critical feedback, this pull request will be merged on October 20th.

@saivann saivann merged commit d1f5f73 into bitcoin-dot-org:master Oct 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment