Wallets: Add KnC Wallet for iOS

[ruuska]

Adding KnC Wallet for iOS to choose-your-wallet.html

KnC Wallet is a SPV, BIP32 deterministic bitcoin wallet for iOS.

KnC Wallet is open source and available under the terms of the MIT license. It is a fork of the excellent breadwallet.

Our iOS wallet has all the same functionality as our android version, such as integration with our KnC Directory and onename.io.

[saivann]

@ruuska The git repository for the wallet contains 4 commits, the first one being a rebased commit importing the whole breadwallet repository along with undocumented changes. Is it possible to not rebase the upstream breadwallet code, and push clear documented commits on top of that repository?

Regarding the pull request:

The default screenshot under mobile: should be left unchanged (Android apps are displayed by default).

Except for important changes in the description (e.g. when the existing one becomes inaccurate), I'd like to ask to avoid changes unless you also provide updated translations.

The wallet score should be the same as breadwallet;

        check:
          control: "checkgoodcontrolfull"
          decentralization: "checkpassvalidationspvp2p"
          transparency: "checkfailtransparencynew"
          environment: "checkpassenvironmentmobile"
          privacy: "checkpassprivacybasic"
        privacycheck:
          privacyaddressreuse: "checkpassprivacyaddressrotation"
          privacydisclosure: "checkfailprivacydisclosurespv"
          privacynetwork: "checkfailprivacynetworknosupporttor"

[ruuska]

@saivann Regarding the git repository; I have not been involved with the development myself and can't answer this right now. I have requested that our app developer ( @trojbom ) takes a look at this.

I did update the pull request per your remarks, please review.

Thanks

[saivann]

Closing for inactivity; previous outlined issues with the source code appear to not have been addressed by developers for a long time, and it seems the wallets from KnC are slowly becoming abandonware. Please feel free to comment if KnC are updating their source code on a non-rebased branch.