Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Dev Docs: Describe Initial Peer Discovery & DNS Seeds #617

Merged
merged 2 commits into from Oct 29, 2014

Conversation

Projects
None yet
4 participants
Contributor

harding commented Oct 25, 2014

Preview: http://dg0.dtrt.org/en/developer-guide#p2p-network

  • Revise P2P Networking section to provide a more detailed description
    of initial peer discovery and DNS seeds.
  • Tweak autocrossref.rb to allow term blacklisting. Then use this new feature
    to prevent cross referencing "address" in "IP address" to the
    definition of Bitcoin P2PKH/P2SH addresses. This avoids a bunch of
    manual "norefs".

@instagibbs: this revises some of your text; please let me know if you see anything I missed.

Note: this is the first of several expansions I plan to make to the P2P Networking and Operating Mode sections over the next couple weeks. I'm breaking them up into medium-sized commits to hopefully make reviewing them less painful than my normal giant commits. :-)

Dev Docs: Describe Initial Peer Discovery & DNS Seeds
* Revise P2P Networking section to provide a more detailed description
  of initial peer discovery and DNS seeds.

* Tweak autocrossref.rb to allow term blacklisting. Use this new feature
  to prevent cross referencing "address" in "IP address" to the
  definition of Bitcoin P2PKH/P2SH addresses.  This avoids a bunch of
  manual "norefs".
Contributor

gmaxwell commented Oct 25, 2014

Should probably also mention the static table of addresses and the ability to manually provision peers.

Contributor

harding commented Oct 25, 2014

@gmaxwell good idea, thanks! Done in commit 4553439 and preview updated.

Contributor

saivann commented Oct 28, 2014

LGTM, thanks! Clever trick in the autocrossref plugin :) .

I've noticed that mainnet and testnet is not consistently uppercased or lowercased everywhere, I can take care to push a commit to lowercase them all once this is merged (it seems lowercase is used more often in devel-reference and devel-examples).

Contributor

harding commented Oct 28, 2014

@saivann thanks! I agree with lowercasing mainnet/testnet. I'm not actually sure how they started getting uppercased.

In the absence of critical feedback, this pull will be merged Wednesday.

Contributor

instagibbs commented Oct 28, 2014

I like the changes, and especially how you are careful to distinguish the consensus rules from p2p protocol, with representative examples core/bitcoinj.

LGTM

Contributor

harding commented Oct 28, 2014

@instagibbs thanks! I've got some more network section changes coming in a separate branch---over 300 lines already written. :-)

Contributor

instagibbs commented Oct 28, 2014

putting the rest of us to shame :) I wonder how much of my original writing is left at all! Great stuff.

Contributor

saivann commented Oct 28, 2014

@instagibbs You're welcome to assign yourself to any new task ;) Thanks for reviewing!

@harding harding merged commit 1604ed5 into bitcoin-dot-org:master Oct 29, 2014

harding added a commit that referenced this pull request Oct 29, 2014

@harding harding deleted the harding:peer-discovery branch Feb 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment