Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Dev Docs: Describe Initial Peer Discovery & DNS Seeds #617
Conversation
|
Should probably also mention the static table of addresses and the ability to manually provision peers. |
|
LGTM, thanks! Clever trick in the autocrossref plugin :) . I've noticed that mainnet and testnet is not consistently uppercased or lowercased everywhere, I can take care to push a commit to lowercase them all once this is merged (it seems lowercase is used more often in devel-reference and devel-examples). |
|
@saivann thanks! I agree with lowercasing mainnet/testnet. I'm not actually sure how they started getting uppercased. In the absence of critical feedback, this pull will be merged Wednesday. |
|
I like the changes, and especially how you are careful to distinguish the consensus rules from p2p protocol, with representative examples core/bitcoinj. LGTM |
|
@instagibbs thanks! I've got some more network section changes coming in a separate branch---over 300 lines already written. :-) |
|
putting the rest of us to shame :) I wonder how much of my original writing is left at all! Great stuff. |
|
@instagibbs You're welcome to assign yourself to any new task ;) Thanks for reviewing! |
harding commentedOct 25, 2014
Preview: http://dg0.dtrt.org/en/developer-guide#p2p-network
of initial peer discovery and DNS seeds.
to prevent cross referencing "address" in "IP address" to the
definition of Bitcoin P2PKH/P2SH addresses. This avoids a bunch of
manual "norefs".
@instagibbs: this revises some of your text; please let me know if you see anything I missed.
Note: this is the first of several expansions I plan to make to the P2P Networking and Operating Mode sections over the next couple weeks. I'm breaking them up into medium-sized commits to hopefully make reviewing them less painful than my normal giant commits. :-)