Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Dev Docs Correction: Checkmultisg Requires Sigs In Same Order As PubKeys #623

Merged
merged 1 commit into from Oct 29, 2014

Conversation

Projects
None yet
2 participants
Contributor

harding commented Oct 29, 2014

Preview: http://dg2.dtrt.org/en/developer-reference#term-op-checkmultisig

As reported by @gsalgado (thanks!), the docs incorrectly state that all sigs are compared against all pubkeys. This commit provides a corrected description, additional details, and references in other parts of the text where we mention multisig. (Fixes #622)

Note: the wiki has the same error, so I'll be updating that momentarily.

Dev Docs Correction: CHECKMULTISIG Requires Sigs In Same Order As Pub…
…Keys

As reported by @gsalgado (thanks!), the docs incorrectly state that all
sigs are compared against all pubkeys.  This commit provides a corrected
description, additional details, and references in other parts of the
text where we mention multisig. (Fixes #622)
Contributor

harding commented Oct 29, 2014

I was able to find a core dev mentioning this situation, providing verification, so I'm going to merge this correction immediately. Comments still welcome here or as new issues.

23:03 sipa shesek: yes, the signatures have to be in the same order as the public keys (http://bitcoinstats.com/irc/bitcoin-dev/logs/2013/11/23)

@harding harding merged commit 1ec7114 into bitcoin-dot-org:master Oct 29, 2014

harding added a commit that referenced this pull request Oct 29, 2014

Contributor

saivann commented Oct 29, 2014

@harding Thanks for digging out this information and updating the wiki too!

@harding harding deleted the harding:checkmsig-order branch Feb 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment